Delete the NPAPI plugin browsertests.

Delete the NPAPI plugin browsertests.

They're not needed anymore now that NPAPI plugin support is disabled.

BUG=493212
Committed: https://crrev.com/a44c8609b62bb2a4a00d18abf61f9fa66a6bef56
Cr-Commit-Position: refs/heads/master@{#334711}

[jam, 2015-06-16 14:22:43]

jam@chromium.org changed reviewers:
+ wfh@chromium.org

[Will Harris, 2015-06-16 16:55:45]

I am concerned that we are removing code that is still being used by PPAPI e.g.
PluginDataRemover is primarily used for Flash.

We do need to implement some kind of template PPAPI plugin that we can use for
tests before we start ripping out more of these tests. The bug for this is
crbug.com/474535 and dcheng@ has offered to do this.

[jam, 2015-06-16 17:15:51]

On 2015/06/16 16:55:45, Will Harris wrote:
> I am concerned that we are removing code that is still being used by PPAPI
e.g.
> PluginDataRemover is primarily used for Flash.

given that the plugin path for npapi and ppapi are different, i didn't see much
value that the npapi-based tests are providing for ppapi

> 
> We do need to implement some kind of template PPAPI plugin that we can use for
> tests before we start ripping out more of these tests. The bug for this is
> crbug.com/474535 and dcheng@ has offered to do this.

[Will Harris, 2015-06-16 17:30:49]

On 2015/06/16 17:15:51, jam wrote:
> On 2015/06/16 16:55:45, Will Harris wrote:
> > I am concerned that we are removing code that is still being used by PPAPI
> e.g.
> > PluginDataRemover is primarily used for Flash.
> 
> given that the plugin path for npapi and ppapi are different, i didn't see
much
> value that the npapi-based tests are providing for ppapi

I agree most of these tests can go, but PluginDataRemover is still used for
PPAPI and we do not want that functionality to regress, so we need a PPAPI test
plugin to use this with, or at least a TODO in the class to add tests for PPAPI.

[jam, 2015-06-16 20:43:44]

On 2015/06/16 17:30:49, Will Harris wrote:
> On 2015/06/16 17:15:51, jam wrote:
> > On 2015/06/16 16:55:45, Will Harris wrote:
> > > I am concerned that we are removing code that is still being used by PPAPI
> > e.g.
> > > PluginDataRemover is primarily used for Flash.
> > 
> > given that the plugin path for npapi and ppapi are different, i didn't see
> much
> > value that the npapi-based tests are providing for ppapi
> 
> I agree most of these tests can go, but PluginDataRemover is still used for
> PPAPI and we do not want that functionality to regress, so we need a PPAPI
test
> plugin to use this with, or at least a TODO in the class to add tests for
PPAPI.

I added a note to the bug about creating ppapi test plugin
https://code.google.com/p/chromium/issues/detail?id=474535#c3

[Will Harris, 2015-06-16 21:01:37]

Sure, as long as this is tracked, the test code can always be restored when the
PPAPI test plugin is added, so lgtm.

[jam, 2015-06-16 21:53:47]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2015-06-16 21:55:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1182303010/80001

[commit-bot: I haz the power, 2015-06-16 22:05:11]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-06-16 22:06:14]

Patchset 5 (id:??) landed as
https://crrev.com/a44c8609b62bb2a4a00d18abf61f9fa66a6bef56
Cr-Commit-Position: refs/heads/master@{#334711}