tools/metrics/histograms/histograms.xml - Issue 1182303005: Fixed the Touchscreen.TouchEventsEnabled histogram to record the correct values on X11 and Ozone ba…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1182303005: Fixed the Touchscreen.TouchEventsEnabled histogram to record the correct values on X11 and Ozone ba… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed compile time issues across the failing platform builds. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« chrome/browser/metrics/chrome_browser_main_extra_parts_metrics_unittest.cc ('K') | « chrome/chrome_tests_unit.gypi ('k') | ui/events/BUILD.gn » ('j') | ui/events/devices/device_data_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 19519a5cbb88a96c4349a6ee3c3d328dff06ba2c..001a67b8f312ea5baa68a946e5650927ea3f8221 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -44950,6 +44950,18 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<owner>pthammaiah@google.com</owner>

</histogram>

+<histogram name="Touchscreen.TouchEventsEnabled" enum="TouchEventsState">

+ <owner>rbyers@chromium.org</owner>

+ <summary>

+ Tracks whether touch events are enabled. This is based on the touch events

+ enabled flag and the presence of a touchscreen.

+ </summary>

+ <details>

+ NOTE: This metric was incorrectly recorded on ChromeOS for versions 42

+ through 44, see http://crbug.com/499476 for more details.

+ </details>

+</histogram>

<owner>oysteine@chromium.org</owner>

@@ -68197,6 +68209,13 @@ To add a new entry, add it with any value and run test to compute valid value.

</enum>

+<enum name="TouchEventsState" type="int">

+ <int value="0" label="Enabled"/>

+ <int value="1" label="Automatic - enabled"/>

+ <int value="2" label="Automatic - disabled"/>

+ <int value="3" label="Disabled"/>

+</enum>

No touchpad detected on a device without built-in touchpad