All private symbols are own symbols

All private symbols are own symbols

R=rossberg@chromium.org
LOG=N
BUG=

Committed: https://crrev.com/a1a7cfd6ba42082179c160d855e4941218a251b7
Cr-Commit-Position: refs/heads/master@{#29041}

[wingo, 2015-06-15 11:39:03]

WDYT?  Given that the previously-specified "private" symbols were junked due to
leaking their keys to proxies, it seems OK to re-appropriate the name "private"
internally to mean private-own symbols.

[rossberg, 2015-06-15 12:09:11]

https://codereview.chromium.org/1182303004/diff/1/src/macros.py
File src/macros.py (right):

https://codereview.chromium.org/1182303004/diff/1/src/macros.py#newcode163
src/macros.py:163: # itself (it should really use %GetOwnProperty, but that
would be way slower).
Is this comment still needed? It seems to work that way now.

https://codereview.chromium.org/1182303004/diff/1/src/macros.py#newcode165
src/macros.py:165: macro NEW_PRIVATE_OWN(name) = (%CreatePrivateSymbol(name));
Rename this to NEW_PRIVATE

https://codereview.chromium.org/1182303004/diff/1/test/mjsunit/harmony/privat...
File test/mjsunit/harmony/private.js (right):

https://codereview.chromium.org/1182303004/diff/1/test/mjsunit/harmony/privat...
test/mjsunit/harmony/private.js:244: // Private symbols key own-properties..
Nit: extra period

https://codereview.chromium.org/1182303004/diff/1/test/mjsunit/own-symbols.js
File test/mjsunit/own-symbols.js (right):

https://codereview.chromium.org/1182303004/diff/1/test/mjsunit/own-symbols.js...
test/mjsunit/own-symbols.js:1: // Copyright 2014 the V8 project authors. All
rights reserved.
This should be merged into harmony/private.js

[Toon Verwaest, 2015-06-15 12:54:16]

verwaest@chromium.org changed reviewers:
+ verwaest@chromium.org

[Toon Verwaest, 2015-06-15 12:54:17]

+1, anything else doesn't seem to make sense

[wingo, 2015-06-16 07:09:46]

Thanks for the review.  Fixed nits, ptal.

https://codereview.chromium.org/1182303004/diff/1/src/macros.py
File src/macros.py (right):

https://codereview.chromium.org/1182303004/diff/1/src/macros.py#newcode163
src/macros.py:163: # itself (it should really use %GetOwnProperty, but that
would be way slower).
On 2015/06/15 12:09:11, rossberg wrote:
> Is this comment still needed? It seems to work that way now.

Removed.

https://codereview.chromium.org/1182303004/diff/1/src/macros.py#newcode165
src/macros.py:165: macro NEW_PRIVATE_OWN(name) = (%CreatePrivateSymbol(name));
On 2015/06/15 12:09:11, rossberg wrote:
> Rename this to NEW_PRIVATE

Done.

https://codereview.chromium.org/1182303004/diff/1/test/mjsunit/harmony/privat...
File test/mjsunit/harmony/private.js (right):

https://codereview.chromium.org/1182303004/diff/1/test/mjsunit/harmony/privat...
test/mjsunit/harmony/private.js:244: // Private symbols key own-properties..
On 2015/06/15 12:09:11, rossberg wrote:
> Nit: extra period

Done.

https://codereview.chromium.org/1182303004/diff/1/test/mjsunit/own-symbols.js
File test/mjsunit/own-symbols.js (right):

https://codereview.chromium.org/1182303004/diff/1/test/mjsunit/own-symbols.js...
test/mjsunit/own-symbols.js:1: // Copyright 2014 the V8 project authors. All
rights reserved.
On 2015/06/15 12:09:11, rossberg wrote:
> This should be merged into harmony/private.js

Done.

[rossberg, 2015-06-16 07:37:11]

lgtm

[wingo, 2015-06-16 07:48:21]

The CQ bit was checked by wingo@igalia.com

[commit-bot: I haz the power, 2015-06-16 07:48:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1182303004/20001

[commit-bot: I haz the power, 2015-06-16 08:13:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-16 08:13:48]

Patchset 2 (id:??) landed as
https://crrev.com/a1a7cfd6ba42082179c160d855e4941218a251b7
Cr-Commit-Position: refs/heads/master@{#29041}