Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1182303003: [turbofan] Mark MachineType as uint16_t. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Mark MachineType as uint16_t. This fixes a few funky implicit conversions for the enum (that are inconsistent across compilers) and also helps to save space, i.e. for the representations_ vector in the InstructionSequence. R=svenpanne@chromium.org Committed: https://crrev.com/f588b1c55030db751f6e9dde08b572a859149754 Cr-Commit-Position: refs/heads/master@{#29011}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -17 lines) Patch
M src/compiler/machine-type.h View 2 chunks +21 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-15 05:29:53 UTC) #1
Benedikt Meurer
Hey Sven, Some simple cleanup. Please take a look. Thanks, Benedikt
5 years, 6 months ago (2015-06-15 05:31:14 UTC) #2
Sven Panne
lgtm
5 years, 6 months ago (2015-06-15 06:25:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182303003/1
5 years, 6 months ago (2015-06-15 06:25:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-15 06:27:14 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-15 06:27:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f588b1c55030db751f6e9dde08b572a859149754
Cr-Commit-Position: refs/heads/master@{#29011}

Powered by Google App Engine
This is Rietveld 408576698