[Android WebView] Implement the capture picture API.

content/public/renderer/render_view_observer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_RENDERER_RENDER_VIEW_OBSERVER_H_
 #define CONTENT_PUBLIC_RENDERER_RENDER_VIEW_OBSERVER_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "content/common/content_export.h"
@@ skipping 81 matching lines @@
   virtual void DidHandleGestureEvent(const WebKit::WebGestureEvent& event) {}
   virtual void DidCreatePepperPlugin(RendererPpapiHost* host) {}
 
   // These match incoming IPCs.
   virtual void Navigate(const GURL& url) {}
   virtual void ClosePage() {}
 
   // IPC::Listener implementation.
   virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
 
+  // IPC::Sender implementation.

[Leandro Graciá Gil, 2013/01/09 16:23:00]

If not moved to public, the IPC_MESSAGE_HANDLER_DELAY_REPLY macro in
aw_render_view_ext.cc throws the following build error:

In file included from android_webview/renderer/aw_render_view_ext.h:12:0,
                 from android_webview/renderer/aw_render_view_ext.cc:5:
ipc/ipc_message_utils.h: In instantiation of 'static bool
IPC::SyncMessageSchema<SendParamType,
ReplyParamType>::DispatchDelayReplyWithSendParams(bool, const SendParam&, const
IPC::Message*, T*, Method) [with T = android_webview::AwRenderViewExt; Method =
void (android_webview::AwRenderViewExt::*)(IPC::Message*); SendParamType =
Tuple0; ReplyParamType = Tuple0; IPC::SyncMessageSchema<SendParamType,
ReplyParamType>::SendParam = Tuple0]':
android_webview/common/render_view_messages.h:57:1:   required from 'static bool
AwViewMsg_CapturePictureSync::DispatchDelayReply(const IPC::Message*, T*,
Method) [with T = android_webview::AwRenderViewExt; Method = void
(android_webview::AwRenderViewExt::*)(IPC::Message*); IPC::Message =
IPC::Message]'
android_webview/renderer/aw_render_view_ext.cc:71:5:   required from here
content/public/renderer/render_view_observer.h:107:16: error: 'virtual bool
content::RenderViewObserver::Send(IPC::Message*)' is protected
In file included from ipc/ipc_message_macros.h:188:0,
                 from content/public/common/common_param_traits_macros.h:16,
                 from content/public/common/common_param_traits.h:19,
                 from android_webview/common/render_view_messages.h:7,
                 from android_webview/renderer/aw_render_view_ext.cc:10:
ipc/ipc_message_utils.h:831:7: error: within this context

I'm open to alternative ways to solve this.

[Jói, 2013/01/09 19:23:45]

Hmm, I don't know if we want to make this public on the class in general,
although that might be OK.  

Could you try making it public only in your subclass, i.e. put something like
this in the public part of your class:

using content::RenderViewObserver::Send;

If this works, please include a comment explaining why this is needed.

[Leandro Graciá Gil, 2013/01/10 18:58:13]

That worked, thanks! No changes required to this file.

On 2013/01/09 19:23:45, Jói wrote:

+  virtual bool Send(IPC::Message* message) OVERRIDE;
+
  protected:
   explicit RenderViewObserver(RenderView* render_view);
   virtual ~RenderViewObserver();
 
-  // IPC::Sender implementation.
-  virtual bool Send(IPC::Message* message) OVERRIDE;
-
   RenderView* render_view() const;
   int routing_id() { return routing_id_; }
 
  private:
   friend class RenderViewImpl;
 
   // This is called by the RenderView when it's going away so that this object
   // can null out its pointer.
   void RenderViewGone();
 
   RenderView* render_view_;
   // The routing ID of the associated RenderView.
   int routing_id_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderViewObserver);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_RENDERER_RENDER_VIEW_OBSERVER_H_