content/renderer/accessibility_node_serializer.cc - Issue 11823026: Adding some new DumpAccessibilityTree tests, tweaking DumpAccessibilityTree helpers and fixing a bug

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/accessibility_node_serializer.cc

Issue 11823026: Adding some new DumpAccessibilityTree tests, tweaking DumpAccessibilityTree helpers and fixing a bug (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix valueNow -> currentValue Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/dump_accessibility_tree_helper_win.cc ('k') | content/test/data/accessibility/address.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/accessibility_node_serializer.cc

diff --git a/content/renderer/accessibility_node_serializer.cc b/content/renderer/accessibility_node_serializer.cc

index be1833cde95280695b7a2b25b2f646503f6b3ae6..164b702c0b7ba618794f587ad230d13d6162a575 100644

--- a/content/renderer/accessibility_node_serializer.cc

+++ b/content/renderer/accessibility_node_serializer.cc

@@ -502,9 +502,9 @@ void SerializeAccessibilityNode(

dst->role == dst->ROLE_SPIN_BUTTON) {

dst->float_attributes[dst->ATTR_VALUE_FOR_RANGE] = src.valueForRange();

dst->float_attributes[dst->ATTR_MAX_VALUE_FOR_RANGE] =

- src.minValueForRange();

- dst->float_attributes[dst->ATTR_MIN_VALUE_FOR_RANGE] =

src.maxValueForRange();

+ dst->float_attributes[dst->ATTR_MIN_VALUE_FOR_RANGE] =

+ src.minValueForRange();

}

if (dst->role == dst->ROLE_DOCUMENT ||