content/browser/accessibility/dump_accessibility_tree_helper_mac.mm - Issue 11823026: Adding some new DumpAccessibilityTree tests, tweaking DumpAccessibilityTree helpers and fixing a bug

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/dump_accessibility_tree_helper_mac.mm

Issue 11823026: Adding some new DumpAccessibilityTree tests, tweaking DumpAccessibilityTree helpers and fixing a bug (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix valueNow -> currentValue Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/dump_accessibility_tree_browsertest.cc ('k') | content/browser/accessibility/dump_accessibility_tree_helper_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/dump_accessibility_tree_helper_mac.mm

diff --git a/content/browser/accessibility/dump_accessibility_tree_helper_mac.mm b/content/browser/accessibility/dump_accessibility_tree_helper_mac.mm

index 6546bd55c7741656ea23d04cd7f9e7587165fa1a..f351f962841ab9f4cb717a9fff733cf13bfbfd4b 100644

--- a/content/browser/accessibility/dump_accessibility_tree_helper_mac.mm

+++ b/content/browser/accessibility/dump_accessibility_tree_helper_mac.mm

@@ -38,8 +38,13 @@ string16 DumpAccessibilityTreeHelper::ToString(BrowserAccessibility* node,

"'"));

Add(true, Format(node, "title='", @selector(title), "'"));

Add(true, Format(node, "value='", @selector(value), "'"));

+ Add(false, Format(node, "minValue='", @selector(minValue), "'"));

+ Add(false, Format(node, "maxValue='", @selector(maxValue), "'"));

+ Add(false, Format(node, "valueDescription='", @selector(valueDescription),

+ "'"));

Add(false, Format(node, "description='", @selector(description), "'"));

Add(false, Format(node, "help='", @selector(help), "'"));

+ Add(false, Format(node, "invalid='", @selector(invalid), "'"));

return ASCIIToUTF16(prefix) + FinishLine() + ASCIIToUTF16("\n");

}