content/browser/accessibility/browser_accessibility_cocoa.mm - Issue 11823026: Adding some new DumpAccessibilityTree tests, tweaking DumpAccessibilityTree helpers and fixing a bug

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_cocoa.mm

Issue 11823026: Adding some new DumpAccessibilityTree tests, tweaking DumpAccessibilityTree helpers and fixing a bug (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix valueNow -> currentValue Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_cocoa.h ('k') | content/browser/accessibility/dump_accessibility_tree_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_cocoa.mm

diff --git a/content/browser/accessibility/browser_accessibility_cocoa.mm b/content/browser/accessibility/browser_accessibility_cocoa.mm

index b3c070f1df163606c38216c29bbccdfefc05d782..b877ea639e4270e1af8d3ceb010164a34f8bbb5c 100644

--- a/content/browser/accessibility/browser_accessibility_cocoa.mm

+++ b/content/browser/accessibility/browser_accessibility_cocoa.mm

@@ -299,6 +299,7 @@ NSDictionary* attributeToMethodNameMap = nil;

{ @"AXARIABusy", @"ariaBusy" },

{ @"AXARIALive", @"ariaLive" },

{ @"AXARIARelevant", @"ariaRelevant" },

+ { @"AXInvalid", @"invalid" },

{ @"AXLoaded", @"loaded" },

{ @"AXLoadingProgress", @"loadingProgress" },

{ @"AXRequired", @"required" },

@@ -483,6 +484,18 @@ NSDictionary* attributeToMethodNameMap = nil;

return [[self role] isEqualToString:NSAccessibilityUnknownRole];

}

+- (NSString*)invalid {

+ string16 invalidUTF;

+ if (!browserAccessibility_->GetHtmlAttribute("aria-invalid", &invalidUTF))

+ return NULL;

+ NSString* invalid = base::SysUTF16ToNSString(invalidUTF);

+ if ([invalid isEqualToString:@"false"] ||

+ [invalid isEqualToString:@""]) {

+ return @"false";

+ }

+ return invalid;

- (NSNumber*)loaded {

return [NSNumber numberWithBool:YES];

}