Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: content/browser/accessibility/dump_accessibility_tree_helper_win.cc

Issue 11823026: Adding some new DumpAccessibilityTree tests, tweaking DumpAccessibilityTree helpers and fixing a bug (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add necessary skip markers and bugs Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/dump_accessibility_tree_helper_win.cc
diff --git a/content/browser/accessibility/dump_accessibility_tree_helper_win.cc b/content/browser/accessibility/dump_accessibility_tree_helper_win.cc
index 3094b39f2318a9b9118e7ee3e2c522adecccdb96..e7fbf214358bcc24276e052a98f0f96c789e9ef6 100644
--- a/content/browser/accessibility/dump_accessibility_tree_helper_win.cc
+++ b/content/browser/accessibility/dump_accessibility_tree_helper_win.cc
@@ -10,6 +10,7 @@
#include "base/file_path.h"
#include "base/string_util.h"
+#include "base/stringprintf.h"
#include "base/utf_string_conversions.h"
#include "content/browser/accessibility/browser_accessibility_win.h"
#include "content/common/accessibility_node_data.h"
@@ -66,7 +67,15 @@ string16 DumpAccessibilityTreeHelper::ToString(
Add(false, *it);
}
Add(false, L"role_name='" + acc_obj->role_name() + L"'");
- Add(false, L"value='" + acc_obj->value() + L"'");
+ VARIANT value;
+ if (acc_obj->get_currentValue(&value) != S_FALSE)
+ Add(false, StringPrintf(L"value=%.2f", V_R8(&value)));
dmazzoni 2013/01/12 00:01:32 Call this numericValue or rangeValue or something
aboxhall 2013/01/12 02:41:46 Done.
+ VARIANT minimumValue;
+ if (acc_obj->get_minimumValue(&minimumValue) != S_FALSE)
+ Add(false, StringPrintf(L"minimumValue=%.2f", V_R8(&minimumValue)));
+ VARIANT maximumValue;
+ if (acc_obj->get_maximumValue(&maximumValue) != S_FALSE)
+ Add(false, StringPrintf(L"maximumValue=%.2f", V_R8(&maximumValue)));
Add(false, L"description='" + description + L"'");
return UTF8ToUTF16(prefix) + FinishLine() + ASCIIToUTF16("\n");
}

Powered by Google App Engine
This is Rietveld 408576698