content/test/data/accessibility/aria-menuitemradio.html - Issue 11823026: Adding some new DumpAccessibilityTree tests, tweaking DumpAccessibilityTree helpers and fixing a bug

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/data/accessibility/aria-menuitemradio.html

Issue 11823026: Adding some new DumpAccessibilityTree tests, tweaking DumpAccessibilityTree helpers and fixing a bug (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add necessary skip markers and bugs Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/test/data/accessibility/address-expected-win.txt ('K') | « content/test/data/accessibility/aria-invalid-expected-win.txt ('k') | content/test/data/accessibility/aria-menuitemradio-expected-mac.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!--

	2 @MAC-ALLOW:roleDescription=*

	3 @MAC-DENY:subrole=(null)

	4 @MAC-DENY:title=''

	5 @MAC-DENY:value=''

	6 @WIN-ALLOW:checkable:*

	7 @WIN-DENY:name=''

	8 -->

	9 <html>

	10 <body>

	11 <div role="aria-menuitemradio" aria-checked>Menu item 1</div>
	dmazzoni 2013/01/12 00:01:32 Should just be role="menuitemradio", no aria in th Should just be role="menuitemradio", no aria in the role. Should you put this in a container with role=menu? aboxhall 2013/01/12 02:41:46 Done, although it doesn't actually make any differ Show quoted text On 2013/01/12 00:01:32, Dominic Mazzoni wrote: > Should just be role="menuitemradio", no aria in the role. > > Should you put this in a container with role=menu? Done, although it doesn't actually make any difference as it turns out.
	12 <div role="aria-menuitemradio">Menu item 2</div>

	13 </body>

	14 </html>

OLD	NEW