Issue 11823023: Unbreak memory_benchmark.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11823023: Unbreak memory_benchmark. (Closed)

Created:
7 years, 11 months ago by marja

Modified:
7 years, 11 months ago

Reviewers:
nduca

CC:
chromium-reviews, chrome-speed-team+watch_google.com, pam+watch_chromium.org, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Unbreak memory_benchmark. It was broken by r175602 ( https://chromiumcodereview.appspot.com/11779041 ). TBR=nduca BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175783

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	tools/telemetry/telemetry/page_benchmark_value.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

marja

7 years, 11 months ago (2013-01-09 12:01:00 UTC) #1

Hi nduca@,

I'll commit this with TBR to unbreak the memory benchmark.

Lots of benchmark tests are still broken (related to
multi_page_benchmark.BenchmarkResults), this CL doesn't fix them.

Expand Messages | Collapse Messages