Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1529)

Unified Diff: content/browser/trace_controller_impl.h

Issue 11823016: Trace category groups and category filter. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Tagged category support cleanup, parameter renaming, documentation updated. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/trace_controller_impl.h
diff --git a/content/browser/trace_controller_impl.h b/content/browser/trace_controller_impl.h
index 2144b54c504b99b0b048380fab9aa627184511e3..1c9cf6d9c02a67338485aecc35b7395c3ca380d2 100644
--- a/content/browser/trace_controller_impl.h
+++ b/content/browser/trace_controller_impl.h
@@ -31,18 +31,21 @@ class TraceControllerImpl : public TraceController {
// once the categories are retrieved from child processes.
bool GetKnownCategoriesAsync(TraceSubscriber* subscriber);
- // Same as above, but specifies which categories to trace.
- // If both included_categories and excluded_categories are empty,
- // all categories are traced.
- // Else if included_categories is non-empty, only those are traced.
- // Else if excluded_categories is non-empty, everything but those are traced.
+ // Same as above, but specifies which categories to trace using tag
+ // patterns.
+ // If both included_tag_patterns and excluded_tag_patterns are empty, all
+ // categories are traced.
+ // Else if included_tag_patterns is non-empty, only those categories that
+ // contain a matching tag, are traced.
+ // Else if excluded_tag_patterns is non-empty, everything but those
+ // categories that have a matching tag are traced.
bool BeginTracing(TraceSubscriber* subscriber,
- const std::vector<std::string>& included_categories,
- const std::vector<std::string>& excluded_categories);
+ const std::vector<std::string>& included_tag_patterns,
+ const std::vector<std::string>& excluded_tag_patterns);
// TraceController implementation:
virtual bool BeginTracing(TraceSubscriber* subscriber,
- const std::string& categories) OVERRIDE;
+ const std::string& tag_patterns) OVERRIDE;
virtual bool EndTracingAsync(TraceSubscriber* subscriber) OVERRIDE;
virtual bool GetTraceBufferPercentFullAsync(
TraceSubscriber* subscriber) OVERRIDE;
@@ -102,8 +105,8 @@ class TraceControllerImpl : public TraceController {
bool is_tracing_;
bool is_get_categories_;
std::set<std::string> known_categories_;
- std::vector<std::string> included_categories_;
- std::vector<std::string> excluded_categories_;
+ std::vector<std::string> included_tag_patterns_;
+ std::vector<std::string> excluded_tag_patterns_;
std::string watch_category_;
std::string watch_name_;

Powered by Google App Engine
This is Rietveld 408576698