Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1494)

Unified Diff: chrome/test/gpu/gpu_feature_browsertest.cc

Issue 11823016: Trace category groups and category filter. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Tagged category support cleanup, parameter renaming, documentation updated. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/gpu/gpu_feature_browsertest.cc
diff --git a/chrome/test/gpu/gpu_feature_browsertest.cc b/chrome/test/gpu/gpu_feature_browsertest.cc
index 97cd8386090f308496021b101263d28d49746ee4..95b54105cb505236f69fca2dfd773c5f576eaa0f 100644
--- a/chrome/test/gpu/gpu_feature_browsertest.cc
+++ b/chrome/test/gpu/gpu_feature_browsertest.cc
@@ -47,7 +47,7 @@ const char kWebGLCreationEvent[] = "DrawingBufferCreation";
class GpuFeatureTest : public InProcessBrowserTest {
public:
- GpuFeatureTest() : trace_categories_("test_gpu"), gpu_enabled_(false) {}
+ GpuFeatureTest() : tag_patterns_("test_gpu"), gpu_enabled_(false) {}
virtual void SetUpInProcessBrowserTestFixture() OVERRIDE {
FilePath test_dir;
@@ -124,7 +124,7 @@ class GpuFeatureTest : public InProcessBrowserTest {
return;
#endif
- ASSERT_TRUE(tracing::BeginTracing(trace_categories_));
+ ASSERT_TRUE(tracing::BeginTracing(tag_patterns_));
// Have to use a new tab for the blacklist to work.
RunTest(url, NULL, true);
@@ -150,10 +150,10 @@ class GpuFeatureTest : public InProcessBrowserTest {
// Trigger a resize of the chrome window, and use tracing to wait for the
// given |wait_event|.
bool ResizeAndWait(const gfx::Rect& new_bounds,
- const char* trace_categories,
+ const char* tag_patterns,
const char* wait_category,
const char* wait_event) {
- if (!tracing::BeginTracingWithWatch(trace_categories, wait_category,
+ if (!tracing::BeginTracingWithWatch(tag_patterns, wait_category,
wait_event, 1))
return false;
browser()->window()->SetBounds(new_bounds);
@@ -169,7 +169,7 @@ class GpuFeatureTest : public InProcessBrowserTest {
protected:
FilePath gpu_test_dir_;
scoped_ptr<TraceAnalyzer> analyzer_;
- std::string trace_categories_;
+ std::string tag_patterns_;
std::string trace_events_json_;
bool gpu_enabled_;
};
@@ -460,7 +460,7 @@ IN_PROC_BROWSER_TEST_F(ThreadedCompositorTest, MAYBE_ThreadedCompositor) {
#define MAYBE_RafNoDamage RafNoDamage
#endif
IN_PROC_BROWSER_TEST_F(GpuFeatureTest, MAYBE_RafNoDamage) {
- trace_categories_ = "-test_*";
+ tag_patterns_ = "-test_*";
const FilePath url(FILE_PATH_LITERAL("feature_raf_no_damage.html"));
RunEventTest(url);

Powered by Google App Engine
This is Rietveld 408576698