chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java - Issue 1182293002: Save image should download the original image when Data Saver is enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

Issue 1182293002: Save image should download the original image when Data Saver is enabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuItemDelegate.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

index 82e96a4a68e23c250cedfc8f4610f5ddefc25d0d..8dd8de02d5fad469bef65af22e3c131f338c28ab 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

@@ -164,14 +164,18 @@ public class ChromeContextMenuPopulator implements ContextMenuPopulator {

mDelegate.onSaveToClipboard(MailTo.parse(params.getLinkUrl()).getTo(), false);

} else if (itemId == R.id.contextmenu_copy_link_text) {

mDelegate.onSaveToClipboard(params.getLinkText(), false);

- } else if (itemId == R.id.contextmenu_save_image

- || itemId == R.id.contextmenu_save_video) {

+ } else if (itemId == R.id.contextmenu_save_image) {

if (mDelegate.startDownload(params.getSrcUrl(), false)) {

- helper.startContextMenuDownload(false);

+ helper.startContextMenuDownload(

+ false, mDelegate.isDataReductionProxyEnabledForURL(params.getSrcUrl()));

+ }

+ } else if (itemId == R.id.contextmenu_save_video) {

+ if (mDelegate.startDownload(params.getSrcUrl(), false)) {

+ helper.startContextMenuDownload(false, false);

}

} else if (itemId == R.id.contextmenu_save_link_as) {

if (mDelegate.startDownload(params.getUnfilteredLinkUrl(), true)) {

- helper.startContextMenuDownload(true);

+ helper.startContextMenuDownload(true, false);

}

} else if (itemId == R.id.contextmenu_search_by_image) {

mDelegate.onSearchByImageInNewTab();