Save image should download the original image when Data Saver is enabled.

content/browser/android/download_controller_android_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/android/download_controller_android_impl.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/bind.h"
 #include "base/logging.h"
@@ skipping 372 matching lines @@
     // if Java DownloadController is not instantiated already.
     JNIEnv* env = base::android::AttachCurrentThread();
     Java_DownloadController_getInstance(env);
   }
 
   DCHECK(java_object_);
   return java_object_;
 }
 
 void DownloadControllerAndroidImpl::StartContextMenuDownload(
-    const ContextMenuParams& params, WebContents* web_contents, bool is_link) {
+    const ContextMenuParams& params, WebContents* web_contents, bool is_link,
+    const std::string& headers) {
   const GURL& url = is_link ? params.link_url : params.src_url;
   const GURL& referring_url = params.frame_url.is_empty() ?
       params.page_url : params.frame_url;
   DownloadManagerImpl* dlm = static_cast<DownloadManagerImpl*>(
       BrowserContext::GetDownloadManager(web_contents->GetBrowserContext()));
   scoped_ptr<DownloadUrlParameters> dl_params(
       DownloadUrlParameters::FromWebContents(web_contents, url));
   content::Referrer referrer = content::Referrer::SanitizeForRequest(
       url,
       content::Referrer(referring_url.GetAsReferrer(),
                         params.referrer_policy));
   dl_params->set_referrer(referrer);
   if (is_link)
     dl_params->set_referrer_encoding(params.frame_charset);
-  else
+  if (!headers.empty()) {
+    std::vector<std::string> key_value_list;
+    base::SplitString(headers, '\n', &key_value_list);

[Ted C, 2015/06/22 20:40:49]

Instead of this, could it use something like
HttpRequestHeaders::AddHeadersFromString?  I was hoping there would be some sort
of shareable logic for this if possible.  (note the \r\n requirement for that
though)

[bengr, 2015/06/22 22:13:10]

Agreed.

[megjablon, 2015/06/22 23:21:02]

I don't see another way to add the headers here other than
DownloadURLParameters::add_request_header. We could modify that or add a
add_request_headers_from_string, but that would just move the splitting logic
elsewhere. web_contents_impl.cc also uses this same strategy to add headers to
DowloadURLParameters.

[Ted C, 2015/06/22 23:25:28]

I was thinking that you would still use
DownloadURLParameters::add_request_header, but HttpRequestHeaders would parse
the string and allows you to iterate over the pair.

i.e.:

net::HttpRequestHeaders headers;
headers.AddHeadersFromString(extra_headers);
for (net::HttpRequestHeaders::Iterator it(headers); it.GetNext();) {
  dl_params->add_request_header(it.name(), it.value());
}

[megjablon, 2015/06/23 00:54:27]

Ah my bad. I misunderstood. Done.

+    for (const auto& key_value : key_value_list) {
+      std::vector<std::string> pair;
+      base::SplitString(key_value, ':', &pair);
+      DCHECK_EQ(2ul, pair.size());
+      dl_params->add_request_header(pair[0], pair[1]);
+    }
+  }
+  if (!is_link && headers.empty())
     dl_params->set_prefer_cache(true);
   dl_params->set_prompt(false);
   dlm->DownloadUrl(dl_params.Pass());
 }
 
 void DownloadControllerAndroidImpl::DangerousDownloadValidated(
     WebContents* web_contents, int download_id, bool accept) {
   if (!web_contents)
     return;
   DownloadManagerImpl* dlm = static_cast<DownloadManagerImpl*>(
@@ skipping 29 matching lines @@
 
   const content::ResourceRequestInfo* info =
       content::ResourceRequestInfo::ForRequest(request);
   if (info)
     has_user_gesture = info->HasUserGesture();
 }
 
 DownloadControllerAndroidImpl::DownloadInfoAndroid::~DownloadInfoAndroid() {}
 
 }  // namespace content