Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1182283002: Plugin Power Saver: Fix Dr. Memory leaks in browser tests. (Closed)

Created:
5 years, 6 months ago by tommycli
Modified:
5 years, 6 months ago
Reviewers:
raymes
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plugin Power Saver: Fix Dr. Memory leaks in browser tests. Power Saver Test Plugin triggers Dr. Memory leaks under Windows. Most likely because the test process is destroyed before the out of process test plugin has a chance to free its Pepper resources (an image data). This is because the test plugin is trying to draw new frames as fast as it possibly can. There's no reason for the test plugin to draw so many frames. In fact, it only needs one. Changing the test plugin to draw only one frame fixes the issue for me (locally). BUG=487492 Committed: https://crrev.com/0a9a5fe4acc84f82314cc7e74f10a3c4348ff0c2 Cr-Commit-Position: refs/heads/master@{#334407}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -35 lines) Patch
M ppapi/examples/gamepad/gamepad.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ppapi/tests/power_saver_test_plugin.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M tools/valgrind/drmemory/suppressions_full.txt View 1 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tommycli
raymes: PTAL, thanks!
5 years, 6 months ago (2015-06-12 22:49:37 UTC) #2
raymes
lgtm
5 years, 6 months ago (2015-06-15 16:06:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182283002/20001
5 years, 6 months ago (2015-06-15 17:25:56 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-15 18:10:28 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-15 18:11:28 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0a9a5fe4acc84f82314cc7e74f10a3c4348ff0c2
Cr-Commit-Position: refs/heads/master@{#334407}

Powered by Google App Engine
This is Rietveld 408576698