Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(218)

Issue 1182253004: Templatize FrameSelection::contains function (Closed)

Created:
4 years, 10 months ago by yosin_UTC9
Modified:
4 years, 10 months ago
Reviewers:
tkent, yoichio
CC:
blink-reviews, hajimehoshi
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Templatize FrameSelection::contains function This patch introduces a template function |containsAlgorithm<Strategy>| to makes |FrameSelection::contains()| function to work both on DOM tree and composed tree with introducing member functions to strategy class |VisibleSelection::InDOMTree|. This patch is result of collaboration work with hajimehoshi@chromium.org for selection of web components. After this patch, we are going to implement another strategies for the composed tree. We've already prepared that at http://crrev.com/1106433002. BUG=275851 TEST=n/a; No behavior changes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197342

Patch Set 1 : 2015-06-18T14:44:59 #

Total comments: 1

Patch Set 2 : 2015-06-18T19:15:03 Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -6 lines) Patch
M Source/core/editing/FrameSelection.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/editing/FrameSelection.cpp View 1 2 chunks +15 lines, -6 lines 0 comments Download
M Source/core/editing/VisibleSelection.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
yosin_UTC9
PTAL
4 years, 10 months ago (2015-06-18 06:18:15 UTC) #3
yosin_UTC9
PTAL
4 years, 10 months ago (2015-06-18 07:28:55 UTC) #5
tkent
lgtm
4 years, 10 months ago (2015-06-18 07:43:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182253004/20001
4 years, 10 months ago (2015-06-18 07:44:19 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/59449)
4 years, 10 months ago (2015-06-18 07:49:08 UTC) #10
yoichio
https://codereview.chromium.org/1182253004/diff/20001/Source/core/editing/FrameSelection.cpp File Source/core/editing/FrameSelection.cpp (right): https://codereview.chromium.org/1182253004/diff/20001/Source/core/editing/FrameSelection.cpp#newcode1296 Source/core/editing/FrameSelection.cpp:1296: template <typename Strategy> VisibleSelection::InDOMTree does not look like other ...
4 years, 10 months ago (2015-06-18 07:59:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182253004/40001
4 years, 10 months ago (2015-06-18 10:16:44 UTC) #15
yosin_UTC9
On 2015/06/18 07:59:15, yoichio wrote: > https://codereview.chromium.org/1182253004/diff/20001/Source/core/editing/FrameSelection.cpp > File Source/core/editing/FrameSelection.cpp (right): > > https://codereview.chromium.org/1182253004/diff/20001/Source/core/editing/FrameSelection.cpp#newcode1296 > ...
4 years, 10 months ago (2015-06-18 10:17:22 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2015-06-18 11:36:30 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197342

Powered by Google App Engine
This is Rietveld 408576698