Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 1182223004: Add a test for the sector app. (Closed)

Created:
5 years, 6 months ago by Hixie
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, gregsimon, jackson_old, abarth-chromium
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add a test for the sector app. This also moves the test for stocks into a new tests/examples/ directory, where we can put tests that test the examples. TBR=abarth Committed: https://chromium.googlesource.com/external/mojo/+/b0664cdcb5e24118f8e9b3a9cb1d71e2cbf90b4f

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+713 lines, -71 lines) Patch
M sky/examples/widgets/sector.dart View 1 chunk +1 line, -1 line 0 comments Download
A sky/tests/examples/sector.dart View 1 chunk +31 lines, -0 lines 0 comments Download
A sky/tests/examples/sector-expected.txt View 1 chunk +683 lines, -0 lines 0 comments Download
A + sky/tests/examples/stocks.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/tests/examples/stocks-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D sky/tests/framework/stocks.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D sky/tests/framework/stocks-expected.txt View 1 chunk +0 lines, -54 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Hixie
5 years, 6 months ago (2015-06-17 22:44:23 UTC) #1
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b0664cdcb5e24118f8e9b3a9cb1d71e2cbf90b4f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698