Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 11822002: Fix downstream android webview build (Closed)

Created:
7 years, 11 months ago by boliu
Modified:
7 years, 11 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, android-webview-reviews_chromium.org, Yaron, aruslan, nyquist
Visibility:
Public.

Description

Fix downstream android webview build from r175537 guava and jsr305 libraries are already present in the downstream build, just need to not use the upstream third_party version and modify the build script BUG= TBR=torne@chromium.org Android only build fix. Ran through android bots with compile step. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175600

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M android_webview/Android.mk View 1 2 chunks +4 lines, -0 lines 0 comments Download
M content/content.gyp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
boliu
avi@ - content.gyp stamp Verified fix works downstream and built upstream locally. Bots seems kind ...
7 years, 11 months ago (2013-01-08 20:20:33 UTC) #1
joth
lgtm https://codereview.chromium.org/11822002/diff/1/android_webview/Android.mk File android_webview/Android.mk (right): https://codereview.chromium.org/11822002/diff/1/android_webview/Android.mk#newcode53 android_webview/Android.mk:53: # content dependency that already exists in android ...
7 years, 11 months ago (2013-01-08 20:37:07 UTC) #2
Avi (use Gerrit)
lgtm stamp
7 years, 11 months ago (2013-01-08 20:48:21 UTC) #3
boliu
https://codereview.chromium.org/11822002/diff/1/android_webview/Android.mk File android_webview/Android.mk (right): https://codereview.chromium.org/11822002/diff/1/android_webview/Android.mk#newcode53 android_webview/Android.mk:53: # content dependency that already exists in android On ...
7 years, 11 months ago (2013-01-08 20:49:24 UTC) #4
boliu
7 years, 11 months ago (2013-01-08 20:49:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/11822002/5001
7 years, 11 months ago (2013-01-08 21:04:55 UTC) #6
commit-bot: I haz the power
7 years, 11 months ago (2013-01-08 22:18:07 UTC) #7
Message was sent while issue was closed.
Change committed as 175600

Powered by Google App Engine
This is Rietveld 408576698