Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 1182193005: [turbofan] Remove the TryLowerDirectJSCall hack from generic lowering. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove the TryLowerDirectJSCall hack from generic lowering. The TryLowerDirectJSCall method tried to lower to a direct JavaScript function call depending on the type of the receiver, but only if the target is a cosntant JSFunction. Since this depends on types and is not required for correctness, it shouldn't be part of generic lowering anyway. So this functionality was moved to typed lowering instead, and we use proper types for the target instead. R=mstarzinger@chromium.org Committed: https://crrev.com/6e5b9ffe4c4691570835607a99bc979f0e7cf3fc Cr-Commit-Position: refs/heads/master@{#29028}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -40 lines) Patch
M src/compiler/js-generic-lowering.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +35 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 3 chunks +30 lines, -0 lines 0 comments Download
M src/types.h View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-15 13:27:46 UTC) #1
Benedikt Meurer
Hey Michi, Some more dehackification; this makes the "direct call" optimization less adhoc, so that ...
5 years, 6 months ago (2015-06-15 13:29:16 UTC) #2
Michael Starzinger
LGTM. Love it.
5 years, 6 months ago (2015-06-15 13:38:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182193005/1
5 years, 6 months ago (2015-06-15 13:38:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-15 14:06:16 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-15 14:06:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e5b9ffe4c4691570835607a99bc979f0e7cf3fc
Cr-Commit-Position: refs/heads/master@{#29028}

Powered by Google App Engine
This is Rietveld 408576698