Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1182193004: MIPS64: Reland 'Enable shorten-64-to-32 warning.' (Closed)

Created:
5 years, 6 months ago by balazs.kilvady
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Reland 'Enable shorten-64-to-32 warning.' Port cdc43bc5fd02fff2905e2e28a79054d0d1eee3ea Original review: https://codereview.chromium.org/1133163005/ Original commit message: Enable clang's shorten-64-to-32 warning flag on ARM64, and fix the warnings that arise. BUG= Committed: https://crrev.com/a12f11911255806d76c016d8332b9b950759c4f9 Cr-Commit-Position: refs/heads/master@{#29024}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -203 lines) Patch
M build/standalone.gypi View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 9 chunks +25 lines, -18 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M src/ic/mips64/stub-cache-mips64.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/mips64/assembler-mips64.h View 2 chunks +5 lines, -3 lines 0 comments Download
M src/mips64/assembler-mips64.cc View 6 chunks +11 lines, -8 lines 0 comments Download
M src/mips64/disasm-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/lithium-codegen-mips64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 22 chunks +33 lines, -29 lines 0 comments Download
M src/mips64/simulator-mips64.h View 3 chunks +41 lines, -41 lines 0 comments Download
M src/mips64/simulator-mips64.cc View 29 chunks +86 lines, -85 lines 0 comments Download
M test/cctest/test-assembler-mips64.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M test/cctest/test-code-stubs-mips64.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
balazs.kilvady
This does need a v8-team review on a standlone.gypi (was LGTMed earlier). We removed the ...
5 years, 6 months ago (2015-06-15 11:17:34 UTC) #2
Jakob Kummerow
lgtm
5 years, 6 months ago (2015-06-15 11:32:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182193004/1
5 years, 6 months ago (2015-06-15 11:44:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-15 12:05:13 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-15 12:05:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a12f11911255806d76c016d8332b9b950759c4f9
Cr-Commit-Position: refs/heads/master@{#29024}

Powered by Google App Engine
This is Rietveld 408576698