Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(20)

Issue 1182133002: Remove unneeded loop from LayoutObject::containingBlock. (Closed)

Created:
4 years, 10 months ago by ojan
Modified:
4 years, 10 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove unneeded loop from LayoutObject::containingBlock. This code originally was added in https://chromium.googlesource.com/chromium/blink/+/d27fecb95d6fb60655506f541422fdc532a6c5dc That megapatch includes it with a comment about positioned element lists inside LayoutInlines. As best I can tell, that's no longer possible in our codebase. I can't tell what other useful thing this code could be doing. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197050

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M Source/core/layout/LayoutObject.cpp View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182133002/1
4 years, 10 months ago (2015-06-12 16:23:56 UTC) #2
ojan
4 years, 10 months ago (2015-06-12 17:14:00 UTC) #4
leviw_travelin_and_unemployed
LGTM. Maybe file a bug if you intend on continuing to hack on this function/merge ...
4 years, 10 months ago (2015-06-12 17:29:04 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2015-06-12 17:43:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182133002/1
4 years, 10 months ago (2015-06-12 17:43:57 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=197050
4 years, 10 months ago (2015-06-12 17:46:55 UTC) #11
mstensho (USE GERRIT)
4 years, 10 months ago (2015-06-16 08:51:17 UTC) #12
Message was sent while issue was closed.
Just a remark here: It was still possible to reach that branch in our codebase.
Consider this:

<span style="position:relative;">
    <div style="position:absolute;"></div>
</span>

We'll end up with a (positioned) LayoutBlock inside a LayoutInline.

As for the usefulness of this... I cannot think of anything (we'll get to the
nearest containing block in due course anyway), so the CL should be good.

Powered by Google App Engine
This is Rietveld 408576698