Componentize HistoryQuickProvider and its supporting cast

Componentize HistoryQuickProvider and its supporting cast

The only thing that's slightly non-trivial is build system changes
around in_memory_url_index_cache.proto.

TBR=phajdan.jr, scottmg

Committed: https://crrev.com/b0d11e2eeb3db9c48bc8b5e068f2e05c7f633a88
Cr-Commit-Position: refs/heads/master@{#335038}

[blundell, 2015-06-16 20:04:00]

blundell@chromium.org changed reviewers:
+ pkasting@chromium.org

[Peter Kasting, 2015-06-16 21:58:30]

I don't see anything nontrivial about the proto build changes -- looks to me
like you just copied the relevant bits from one file to another.

LGTM

https://codereview.chromium.org/1182113009/diff/1/components/omnibox/BUILD.gn
File components/omnibox/BUILD.gn (right):

https://codereview.chromium.org/1182113009/diff/1/components/omnibox/BUILD.gn...
components/omnibox/BUILD.gn:4:
import("//third_party/protobuf/proto_library.gni")
Nit: Blank line above this

[blundell, 2015-06-17 14:16:09]

On 2015/06/16 21:58:30, Peter Kasting wrote:
> I don't see anything nontrivial about the proto build changes -- looks to me
> like you just copied the relevant bits from one file to another.
>

That's what it ended up being -- it required a little analysis of the usage of
the generated header to see that the direct dep from //chrome/browser could go
away and that //components/omnibox didn't need the proto dep as a public dep.
 
> LGTM
> 
> https://codereview.chromium.org/1182113009/diff/1/components/omnibox/BUILD.gn
> File components/omnibox/BUILD.gn (right):
> 
>
https://codereview.chromium.org/1182113009/diff/1/components/omnibox/BUILD.gn...
> components/omnibox/BUILD.gn:4:
> import("//third_party/protobuf/proto_library.gni")
> Nit: Blank line above this

[blundell, 2015-06-17 14:16:18]

https://codereview.chromium.org/1182113009/diff/1/components/omnibox/BUILD.gn
File components/omnibox/BUILD.gn (right):

https://codereview.chromium.org/1182113009/diff/1/components/omnibox/BUILD.gn...
components/omnibox/BUILD.gn:4:
import("//third_party/protobuf/proto_library.gni")
On 2015/06/16 21:58:29, Peter Kasting wrote:
> Nit: Blank line above this

Done.

[blundell, 2015-06-18 13:01:34]

The CQ bit was checked by blundell@chromium.org to run a CQ dry run

[blundell, 2015-06-18 13:01:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/1182113009/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2015-06-18 13:02:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1182113009/40001

[commit-bot: I haz the power, 2015-06-18 13:12:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-18 13:12:43]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[blundell, 2015-06-18 14:33:33]

blundell@chromium.org changed reviewers:
+ phajdan.jr@chromium.org, scottmg@chromium.org

[blundell, 2015-06-18 14:34:22]

TBR=phajdan.jr for //chrome/test/base
TBR=scottmg for dep from //components/omnibox to //third_party/protobuf

[blundell, 2015-06-18 14:34:27]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2015-06-18 14:36:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1182113009/40001

[commit-bot: I haz the power, 2015-06-18 14:41:37]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-18 14:42:45]

Patchset 3 (id:??) landed as
https://crrev.com/b0d11e2eeb3db9c48bc8b5e068f2e05c7f633a88
Cr-Commit-Position: refs/heads/master@{#335038}