Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1182113007: Hydrogen object literals: always initialize in-object properties (Closed)

Created:
5 years, 6 months ago by Jakob Kummerow
Modified:
5 years, 6 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Hydrogen object literals: always initialize in-object properties This fixes a bug where new-space GC could be triggered by non-folded allocations for some of the in-object properties, while the object was only partially initialized. BUG=chromium:500497 LOG=y R=ishell@chromium.org Committed: https://crrev.com/5fca3947cf52f5ff2c5d094281a38347eb9df68f Cr-Commit-Position: refs/heads/master@{#29079}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -15 lines) Patch
M src/hydrogen.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 5 chunks +25 lines, -14 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-500497.js View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jakob Kummerow
PTAL
5 years, 6 months ago (2015-06-16 15:37:29 UTC) #1
Igor Sheludko
lgtm
5 years, 6 months ago (2015-06-17 10:44:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182113007/1
5 years, 6 months ago (2015-06-17 10:46:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-17 11:24:20 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 11:24:33 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5fca3947cf52f5ff2c5d094281a38347eb9df68f
Cr-Commit-Position: refs/heads/master@{#29079}

Powered by Google App Engine
This is Rietveld 408576698