Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 1182113004: Change return type of printPage (Part#4) (Closed)

Created:
5 years, 6 months ago by Habib Virji
Modified:
5 years, 6 months ago
Reviewers:
pdr.
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Change return type of printPage (Part#4) Adds two function of printPage with function differing by a parameter. Also includes two calls to printPage, where one is implemented and other is not implemented on the chromium side. printPage method with three parameters will be removed once chromium side lands. R=pdr BUG=496765 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197192

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/web/WebPluginContainerImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M public/web/WebPlugin.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182113004/1
5 years, 6 months ago (2015-06-16 10:25:40 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-16 11:37:52 UTC) #4
Habib Virji
After this patch it is set of one patch in chromium and blink to be ...
5 years, 6 months ago (2015-06-16 11:39:11 UTC) #5
pdr.
lgtm
5 years, 6 months ago (2015-06-16 20:42:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182113004/1
5 years, 6 months ago (2015-06-16 20:44:47 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 20:49:14 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197192

Powered by Google App Engine
This is Rietveld 408576698