test/linux/implicit-rpath/test.gyp - Issue 11821060: Change ninja rpath generation to be more like make.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: test/linux/implicit-rpath/test.gyp

Issue 11821060: Change ninja rpath generation to be more like make. Base URL: http://gyp.googlecode.com/svn/trunk/

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright (c) 2012 Google Inc. All rights reserved.
	Nico 2013/01/10 21:34:57 nit: 2013 nit: 2013 cwolfe 2013/01/10 21:49:47 Done. Show quoted text On 2013/01/10 21:34:57, Nico wrote: > nit: 2013 Done.
	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4 {

	5 'targets': [

	6 {

	7 'target_name': 'shared',

	8 'type': 'shared_library',

	9 'sources': [ 'file.c' ],

	10 },

	11 {

	12 'target_name': 'static',

	13 'type': 'static_library',

	14 'sources': [ 'file.c' ],

	15 },

	16 {

	17 'target_name': 'shared_executable',

	18 'type': 'executable',

	19 'sources': [ 'main.c' ],

	20 'dependencies': [

	21 'shared'
	Nico 2013/01/10 21:34:57 nit: i'd put a trailing , here nit: i'd put a trailing , here cwolfe 2013/01/10 21:49:47 Done. Show quoted text On 2013/01/10 21:34:57, Nico wrote: > nit: i'd put a trailing , here Done.
	22 ]

	23 },

	24 {

	25 'target_name': 'static_executable',

	26 'type': 'executable',

	27 'sources': [ 'main.c' ],

	28 'dependencies': [

	29 'static'
	Nico 2013/01/10 21:34:57 here too here too cwolfe 2013/01/10 21:49:47 Done. Show quoted text On 2013/01/10 21:34:57, Nico wrote: > here too Done.
	30 ]

	31 },

	32 ],

	33 }

OLD	NEW