Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 11821053: Revert 176087 (Closed)

Created:
7 years, 11 months ago by acolwell GONE FROM CHROMIUM
Modified:
7 years, 11 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, dbeam+watch-options_chromium.org, dtseng+watch_chromium.org, sadrul, nkostylev+watch_chromium.org, hashimoto+watch_chromium.org, ben+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, arv (Not doing code reviews), dmazzoni+watch_chromium.org, oshima+watch_chromium.org, ctguil+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, zork+watch_chromium.org
Visibility:
Public.

Description

Revert 176087 Appears to break ChromeOS browser_tests. > Re-introduce the partial magnifier > > Major Changes: > - Adding a selectbox at the right of screen magnifier setting on the setting page. > - Adding 'screen_magnifier_type2' pref. > - Separating the enable/disable state of magnifier from MagnifierType. MagnifierType does no longer indicate the current enable/disable status. > - Add IsMagnifierEnabled() to shell delegate. > > BUG=166832 > TEST=confirm that magnifier can be enabled/disabled via the tray and the settings page. browser_test passes. > > R=zork@chromium.org, derat@chromium.org, nkostylev@chromium.org > TBR=jhawkins@chromium.org > # TBRing for small changed in C/B/ui/webui/options/ and C/B/resources/options/ > > Review URL: https://chromiumcodereview.appspot.com/11642014 TBR=yoshiki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176102

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -533 lines) Patch
M ash/magnifier/magnifier_constants.h View 1 chunk +3 lines, -7 lines 0 comments Download
M ash/shell/shell_delegate_impl.h View 2 chunks +1 line, -4 lines 0 comments Download
M ash/shell/shell_delegate_impl.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M ash/shell_delegate.h View 1 chunk +2 lines, -8 lines 0 comments Download
M ash/system/tray_accessibility.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M ash/test/test_shell_delegate.h View 2 chunks +1 line, -4 lines 0 comments Download
M ash/test/test_shell_delegate.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_util.h View 2 chunks +6 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_util.cc View 3 chunks +28 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/accessibility/magnification_manager.h View 1 chunk +3 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/accessibility/magnification_manager.cc View 4 chunks +34 lines, -96 lines 0 comments Download
M chrome/browser/chromeos/accessibility/magnification_manager_browsertest.cc View 8 chunks +122 lines, -270 lines 0 comments Download
MM chrome/browser/chromeos/preferences.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/preferences.cc View 4 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/chromeos/system/tray_accessibility_browsertest.cc View 14 chunks +28 lines, -25 lines 0 comments Download
M chrome/browser/resources/options/browser_options.html View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/ash_init.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 chunk +3 lines, -19 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc View 2 chunks +6 lines, -2 lines 0 comments Download
MM chrome/browser/ui/webui/options/browser_options_handler.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
acolwell GONE FROM CHROMIUM
7 years, 11 months ago (2013-01-10 16:46:18 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698