Move power event handling logic from ui/ to base/ on Windows

base/system_monitor/system_monitor.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_SYSTEM_MONITOR_SYSTEM_MONITOR_H_
 #define BASE_SYSTEM_MONITOR_SYSTEM_MONITOR_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 116 matching lines @@
   // Remove an existing observer.
   // Can be called from any thread.
   // Must not be called from within a notification callback.
   void RemovePowerObserver(PowerObserver* obs);
   void RemoveDevicesChangedObserver(DevicesChangedObserver* obs);
 
   // The ProcessFoo() style methods are a broken pattern and should not
   // be copied. Any significant addition to this class is blocked on
   // refactoring to improve the state of affairs. See http://crbug.com/149059
 
-#if defined(OS_WIN)
-  // Windows-specific handling of a WM_POWERBROADCAST message.
-  // Embedders of this API should hook their top-level window
-  // message loop and forward WM_POWERBROADCAST through this call.
-  void ProcessWmPowerBroadcastMessage(int event_id);
-#endif
-
   // Cross-platform handling of a power event.
   void ProcessPowerMessage(PowerEvent event_id);
 
   // Cross-platform handling of a device change event.
   void ProcessDevicesChanged(DeviceType device_type);
 
  private:
-#if defined(OS_MACOSX)
+#if defined(OS_MACOSX) || defined(OS_WIN)

[vandebo (ex-Chrome), 2013/02/21 19:47:17]

Remove change - you don't have PlatformInit/Desotry on Windows now.

[Hongbo Min, 2013/02/22 06:55:43]

Done.

   void PlatformInit();
   void PlatformDestroy();
 #endif
 
+#if defined(OS_WIN)
+  // Represents a message-only window for power message handling on Windows.
+  // Only allow SystemMonitor to create it.
+  class PowerMessageWindow {

[vandebo (ex-Chrome), 2013/02/21 19:47:17]

Brett's point was that this can be an anonymous class in the .cpp file.  You
just have to declare the class and use a scoped_ptr to it here.

[Hongbo Min, 2013/02/22 06:55:43]

The problem is, if we just declare the class here and use a scoped_ptr to hold
it, the class MUST be defined in the system_monitor.cc using OS_WIN macro.
Otherwise, if it is defined in system_monitor_win.cc, we will get a compile
error saying 'use of undefined type' when compiling system_monitor.cc. The
forwarding class declaration should not cross 2 translation units, right?

So is it worthy to define the PowerMessageWindow in system_monitor.cc using
OS_WIN macro although a platform specific file system_monitor_win.cc is there?
See the PatchSet 5.

[vandebo (ex-Chrome), 2013/02/23 01:14:53]

Good point.  Put it in system_monitor_win.cc and use PlatformInit to create it.

+   private:
+    friend class SystemMonitor;

[vandebo (ex-Chrome), 2013/02/21 19:47:17]

Looks like won't need this friend declaration after you make it anonymous
because you can make the ctor and dtor public.

[Hongbo Min, 2013/02/22 06:55:43]

Actually, no need to make ctor and dtor as private since the inner class is also
declared as a private in SystemMonitor.

+
+    PowerMessageWindow();
+    ~PowerMessageWindow();
+    void ProcessWmPowerBroadcastMessage(int event_id);
+    LRESULT CALLBACK WndProc(HWND hwnd, UINT message,
+                             WPARAM wparam, LPARAM lparam);
+    static LRESULT CALLBACK WndProcThunk(HWND hwnd,
+                                         UINT message,
+                                         WPARAM wparam,
+                                         LPARAM lparam);
+    // Instance of the module containing the window procedure.
+    HMODULE instance_;
+    // A hidden message-only window.
+    HWND message_hwnd_;
+  };
+
+  PowerMessageWindow power_message_window_;
+#endif
+
   // Platform-specific method to check whether the system is currently
   // running on battery power.  Returns true if running on batteries,
   // false otherwise.
   bool IsBatteryPower();
 
   // Checks the battery status and notifies observers if the battery
   // status has changed.
   void BatteryCheck();
 
   // Functions to trigger notifications.
@@ skipping 16 matching lines @@
   // Holds pointers to system event notification observers.
   std::vector<id> notification_observers_;
 #endif
 
   DISALLOW_COPY_AND_ASSIGN(SystemMonitor);
 };
 
 }  // namespace base
 
 #endif  // BASE_SYSTEM_MONITOR_SYSTEM_MONITOR_H_