Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 11821030: mac: Tweak minimum tab width to look good on retina displays too (Closed)

Created:
7 years, 11 months ago by Nico
Modified:
7 years, 11 months ago
Reviewers:
Robert Sesek, sail
CC:
chromium-reviews, sail+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

mac: Tweak minimum tab width to look good on retina displays too BUG=168820 TEST=open lots and lots of tabs. The close button stays centered in the selected tab, and the background tabs don't become so small that they look clipped. If too many tabs are opened, they just wander out of the window to the right, like previously -- this time do this on a retina display. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175857

Patch Set 1 #

Patch Set 2 : gitgitgit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/cocoa/tabs/tab_controller.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
I hope reviewing these stimulates you intellectually just as much writing them stimulates me.
7 years, 11 months ago (2013-01-09 18:27:25 UTC) #1
Nico
sail seems to not come in before noon these days.
7 years, 11 months ago (2013-01-09 19:52:49 UTC) #2
Robert Sesek
7 years, 11 months ago (2013-01-09 19:53:04 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698