Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11821028: Browser Plugin: Make sure name attribute is propagated to guest if it's set prior to initializing p… (Closed)

Created:
7 years, 11 months ago by Fady Samuel
Modified:
7 years, 11 months ago
Reviewers:
sadrul
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Browser Plugin: Make sure name attribute is propagated to guest if it's set prior to initializing plugin + cleanup. BUG=140316 Test=BrowserPluginHostTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175914

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated test #

Total comments: 1

Patch Set 3 : Fixed nit #

Patch Set 4 : Fixed breakage on certain compilers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -9 lines) Patch
M content/browser/browser_plugin/browser_plugin_host_browsertest.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 1 2 3 4 chunks +13 lines, -9 lines 0 comments Download
M content/test/data/browser_plugin_naming_embedder.html View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Fady Samuel
Fairly trivial change + cleanup
7 years, 11 months ago (2013-01-09 18:03:08 UTC) #1
sadrul
https://codereview.chromium.org/11821028/diff/1/content/renderer/browser_plugin/browser_plugin.cc File content/renderer/browser_plugin/browser_plugin.cc (right): https://codereview.chromium.org/11821028/diff/1/content/renderer/browser_plugin/browser_plugin.cc#newcode656 content/renderer/browser_plugin/browser_plugin.cc:656: SetNameAttribute(params.attributeValues[i].utf8()); Can this be tested?
7 years, 11 months ago (2013-01-09 18:04:29 UTC) #2
Fady Samuel
https://codereview.chromium.org/11821028/diff/1/content/renderer/browser_plugin/browser_plugin.cc File content/renderer/browser_plugin/browser_plugin.cc (right): https://codereview.chromium.org/11821028/diff/1/content/renderer/browser_plugin/browser_plugin.cc#newcode656 content/renderer/browser_plugin/browser_plugin.cc:656: SetNameAttribute(params.attributeValues[i].utf8()); On 2013/01/09 18:04:29, sadrul wrote: > Can this ...
7 years, 11 months ago (2013-01-09 18:19:37 UTC) #3
sadrul
LGTM https://codereview.chromium.org/11821028/diff/2002/content/renderer/browser_plugin/browser_plugin.cc File content/renderer/browser_plugin/browser_plugin.cc (right): https://codereview.chromium.org/11821028/diff/2002/content/renderer/browser_plugin/browser_plugin.cc#newcode93 content/renderer/browser_plugin/browser_plugin.cc:93: default: Instead of default, case TERMINATION_STATUS_STILL_RUNNING and TERMINATION_STATUS_MAX_ENUM, ...
7 years, 11 months ago (2013-01-09 18:42:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/11821028/2003
7 years, 11 months ago (2013-01-09 19:28:25 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 11 months ago (2013-01-09 19:53:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/11821028/11004
7 years, 11 months ago (2013-01-09 20:12:33 UTC) #7
commit-bot: I haz the power
7 years, 11 months ago (2013-01-09 23:18:15 UTC) #8
Message was sent while issue was closed. 
Change committed as 175914

Powered by Google App Engine
This is Rietveld 408576698