Fix a bug in pkg/http where exceptions were getting top-leveled.

Fix a bug in pkg/http where exceptions were getting top-leveled.

It's very important that the Future chain be set up synchronously. This error
crept in because I tried to use a pre-existing Future as the return value of a
.then callback, and that future fired an error before it was chained in.

[Bob Nystrom, 2013-01-09 16:09:21]

LGTM.

Though it scares me how subtle this bug is. I worry that other users of
Future/Streams will run into this too.

Florian, Is there a way the core API can help prevent this?

https://codereview.chromium.org/11821018/diff/1/pkg/http/test/client_test.dart
File pkg/http/test/client_test.dart (right):

https://codereview.chromium.org/11821018/diff/1/pkg/http/test/client_test.dar...
pkg/http/test/client_test.dart:48: 'application/json; charset=utf-8';
Nit: indent +2 more.

[floitsch, 2013-01-09 17:48:31]

LGTM.

Thanks for bringing this to our attention.

https://codereview.chromium.org/11821018/diff/1/pkg/http/lib/src/io_client.dart
File pkg/http/lib/src/io_client.dart (right):

https://codereview.chromium.org/11821018/diff/1/pkg/http/lib/src/io_client.da...
pkg/http/lib/src/io_client.dart:76: return Futures.wait([
We are going to remove the Futures class.
We have created new Future.wait(...) to replace this static method.

[nweiz, 2013-01-09 21:03:40]

https://codereview.chromium.org/11821018/diff/1/pkg/http/lib/src/io_client.dart
File pkg/http/lib/src/io_client.dart (right):

https://codereview.chromium.org/11821018/diff/1/pkg/http/lib/src/io_client.da...
pkg/http/lib/src/io_client.dart:76: return Futures.wait([
On 2013/01/09 17:48:31, floitsch wrote:
> We are going to remove the Futures class.
> We have created new Future.wait(...) to replace this static method.

Done.

https://codereview.chromium.org/11821018/diff/1/pkg/http/test/client_test.dart
File pkg/http/test/client_test.dart (right):

https://codereview.chromium.org/11821018/diff/1/pkg/http/test/client_test.dar...
pkg/http/test/client_test.dart:48: 'application/json; charset=utf-8';
On 2013/01/09 16:09:21, Bob Nystrom wrote:
> Nit: indent +2 more.

Done.