Get more pub tests working.

utils/tests/pub/test_pub.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Test infrastructure for testing pub. Unlike typical unit tests, most pub
 /// tests are integration tests that stage some stuff on the file system, run
 /// pub, and then validate the results. This library provides an API to build
 /// tests like that.
 library test_pub;
 
@@ skipping 816 matching lines @@
       checkComplete() {
         if (failures.length + successes != matches.length) return;
         if (successes > 0) {
           completer.complete(null);
           return;
         }
 
         var error = new StringBuffer();
         error.add("No files named $name in $dir were valid:\n");
         for (var failure in failures) {
-          error.add("  ").add(failure).add("\n");
+          error.add("  $failure\n");
         }
-        completer.completeException(
+        completer.completeError(
             new ExpectException(error.toString()), stackTrace);
       }
 
       for (var match in matches) {
         var future = validate(match);
 
         future.catchError((e) {
           failures.add(e);
           checkComplete();
         });
 
         future.then((_) {
           successes++;
           checkComplete();
-        }).catchError(() {});
+        }).catchError((_) {});
       }
       return completer.future;
     });
   }
 }
 
 /// Describes a file. These are used both for setting up an expected directory
 /// tree before running a test, and for validating that the file system matches
 /// some expectations after running it.
 class FileDescriptor extends Descriptor {
@@ skipping 686 matching lines @@
 /// calling [completion] is unnecessary.
 void expectLater(Future actual, matcher, {String reason,
     FailureHandler failureHandler, bool verbose: false}) {
   _schedule((_) {
     return actual.then((value) {
       expect(value, matcher, reason: reason, failureHandler: failureHandler,
           verbose: false);
     });
   });
 }