Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 11821002: mac: Tweak minimum tab width to match bitmap assets (Closed)

Created:
7 years, 11 months ago by Nico
Modified:
7 years, 11 months ago
Reviewers:
sail
CC:
chromium-reviews, sail+watch_chromium.org
Visibility:
Public.

Description

mac: Tweak minimum tab width to match bitmap assets BUG=168820, 166115 TEST=open lots and lots of tabs. The close button stays centered in the selected tab, and the background tabs don't become so small that they look clipped. If too many tabs are opened, they just wander out of the window to the right, like previously. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175580

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M chrome/browser/ui/cocoa/tabs/tab_controller.mm View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
7 years, 11 months ago (2013-01-08 19:52:04 UTC) #1
sail
LGTM Any chance we could do something like this instead? https://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/browser/ui/views/tabs/tab.cc&exact_package=chromium&q=GetBasicMinimumUnselectedSize&type=cs&l=587
7 years, 11 months ago (2013-01-08 19:56:11 UTC) #2
Nico
On Tue, Jan 8, 2013 at 11:56 AM, <sail@chromium.org> wrote: > LGTM > > Any ...
7 years, 11 months ago (2013-01-08 20:02:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/11821002/1
7 years, 11 months ago (2013-01-08 20:02:18 UTC) #4
Nico
7 years, 11 months ago (2013-01-08 20:02:34 UTC) #5
Thanks!

Resending comment through rietveld, since my email didn't make it there.

On 2013/01/08 19:56:11, sail wrote:
> LGTM
> 
> Any chance we could do something like this instead?
>
https://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/browser/ui/views/t...

I thought about that, but since there's a fairly arbitrary constant in
there to account for the transparent pixels on the right, it didn't
seem worth it.

Powered by Google App Engine
This is Rietveld 408576698