Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4620)

Unified Diff: chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.cc

Issue 1182083005: Re-engineer edit screen in enhanced bookmark (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove description code in native, use new UI wedgit Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.cc
diff --git a/chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.cc b/chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.cc
index ded87ea9b1b28a02b4654d1ebf6e38c7d11e95f1..04634fb1a57f6e772a7eeeec34c483aa50f943f4 100644
--- a/chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.cc
+++ b/chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.cc
@@ -95,36 +95,6 @@ void EnhancedBookmarksBridge::FetchImageForTab(JNIEnv* env,
web_contents, web_contents->GetURL(), true);
}
-ScopedJavaLocalRef<jstring> EnhancedBookmarksBridge::GetBookmarkDescription(
- JNIEnv* env, jobject obj, jlong id, jint type) {
- DCHECK(enhanced_bookmark_model_->loaded());
- if (type != BookmarkType::BOOKMARK_TYPE_NORMAL) {
- return base::android::ConvertUTF8ToJavaString(env, std::string());
- }
-
- const BookmarkNode* node = bookmarks::GetBookmarkNodeByID(
- enhanced_bookmark_model_->bookmark_model(), static_cast<int64>(id));
-
- return node ? base::android::ConvertUTF8ToJavaString(
- env, enhanced_bookmark_model_->GetDescription(node))
- : ScopedJavaLocalRef<jstring>();
-}
-
-void EnhancedBookmarksBridge::SetBookmarkDescription(JNIEnv* env,
- jobject obj,
- jlong id,
- jint type,
- jstring description) {
- DCHECK(enhanced_bookmark_model_->loaded());
- DCHECK_EQ(type, BookmarkType::BOOKMARK_TYPE_NORMAL);
-
- const BookmarkNode* node = bookmarks::GetBookmarkNodeByID(
- enhanced_bookmark_model_->bookmark_model(), static_cast<int64>(id));
-
- enhanced_bookmark_model_->SetDescription(
- node, base::android::ConvertJavaStringToUTF8(env, description));
-}
-
ScopedJavaLocalRef<jobject> EnhancedBookmarksBridge::AddFolder(JNIEnv* env,
jobject obj,
jobject j_parent_id_obj,
« no previous file with comments | « chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698