chrome/android/java_staging/src/org/chromium/chrome/browser/ntp/BookmarkItemView.java - Issue 1182083005: Re-engineer edit screen in enhanced bookmark

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java_staging/src/org/chromium/chrome/browser/ntp/BookmarkItemView.java

Issue 1182083005: Re-engineer edit screen in enhanced bookmark (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove description code in native, use new UI wedgit Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java_staging/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUtils.java ('k') | chrome/android/javatests_shell/src/org/chromium/chrome/browser/enhanced_bookmarks/EnhancedBookmarksModelTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java_staging/src/org/chromium/chrome/browser/ntp/BookmarkItemView.java

diff --git a/chrome/android/java_staging/src/org/chromium/chrome/browser/ntp/BookmarkItemView.java b/chrome/android/java_staging/src/org/chromium/chrome/browser/ntp/BookmarkItemView.java

index 3f929d18cc540a41ec8d0c3f023125f3ebc4f6c0..10e2143c879faf426de48dd98ca13268fa7f4229 100644

--- a/chrome/android/java_staging/src/org/chromium/chrome/browser/ntp/BookmarkItemView.java

+++ b/chrome/android/java_staging/src/org/chromium/chrome/browser/ntp/BookmarkItemView.java

@@ -219,9 +219,9 @@ class BookmarkItemView extends AppCompatTextView implements OnCreateContextMenuL

R.string.contextmenu_open_in_incognito_tab).setOnMenuItemClickListener(this);

}

if (mIsEditable && !mManager.isIncognito()) {

- menu.add(Menu.NONE, ID_EDIT, Menu.NONE, mIsFolder

- ? R.string.contextmenu_edit_folder : R.string.contextmenu_edit_bookmark)

- .setOnMenuItemClickListener(this);

+ menu.add(Menu.NONE, ID_EDIT, Menu.NONE,

+ mIsFolder ? R.string.contextmenu_edit_folder : R.string.edit_bookmark)

+ .setOnMenuItemClickListener(this);

menu.add(Menu.NONE, ID_DELETE, Menu.NONE, mIsFolder

? R.string.contextmenu_delete_folder : R.string.contextmenu_delete_bookmark)

.setOnMenuItemClickListener(this);