Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: chrome/android/java_staging/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkManager.java

Issue 1182083005: Re-engineer edit screen in enhanced bookmark (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove description code in native, use new UI wedgit Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java_staging/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkManager.java
diff --git a/chrome/android/java_staging/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkManager.java b/chrome/android/java_staging/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkManager.java
index ae4fb41c67f73c8156ef14194aea847b61f50b5b..76aa99a606ccd6984c6eb048de3efb4c1eff2353 100644
--- a/chrome/android/java_staging/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkManager.java
+++ b/chrome/android/java_staging/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkManager.java
@@ -4,11 +4,7 @@
package org.chromium.chrome.browser.enhancedbookmarks;
-import android.annotation.TargetApi;
import android.app.Activity;
-import android.app.ActivityOptions;
-import android.content.Intent;
-import android.os.Build;
import android.preference.PreferenceManager;
import android.support.v4.widget.DrawerLayout;
import android.util.Log;
@@ -30,7 +26,6 @@ import org.chromium.chrome.browser.ntp.NewTabPageUma;
import org.chromium.chrome.browser.partnerbookmarks.PartnerBookmarksShim;
import org.chromium.chrome.browser.snackbar.SnackbarManager.SnackbarManageable;
import org.chromium.components.bookmarks.BookmarkId;
-import org.chromium.ui.base.DeviceFormFactor;
import java.io.UnsupportedEncodingException;
import java.net.URLDecoder;
@@ -427,22 +422,6 @@ public class EnhancedBookmarkManager implements EnhancedBookmarkDelegate {
}
@Override
- @TargetApi(Build.VERSION_CODES.LOLLIPOP)
- public void startDetailActivity(BookmarkId bookmarkId, View view) {
- Intent intent = new Intent(mActivity, EnhancedBookmarkDetailActivity.class);
- intent.putExtra(EnhancedBookmarkDetailActivity.INTENT_BOOKMARK_ID, bookmarkId.toString());
- // Shared element animation is disabled on tablet because of bad quality.
- if (Build.VERSION.SDK_INT < Build.VERSION_CODES.LOLLIPOP || view == null
- || DeviceFormFactor.isTablet(mActivity)) {
- mActivity.startActivity(intent);
- } else {
- ActivityOptions options = ActivityOptions.makeSceneTransitionAnimation(mActivity, view,
- mActivity.getString(R.string.enhanced_bookmark_detail_transition_name));
- mActivity.startActivity(intent, options.toBundle());
- }
- }
-
- @Override
public void openBookmark(BookmarkId bookmark, int launchLocation) {
clearSelection();
NewTabPageUma.recordAction(NewTabPageUma.ACTION_OPENED_BOOKMARK);

Powered by Google App Engine
This is Rietveld 408576698