Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: chrome/android/java_staging/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkDelegate.java

Issue 1182083005: Re-engineer edit screen in enhanced bookmark (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove description code in native, use new UI wedgit Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java_staging/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkDelegate.java
diff --git a/chrome/android/java_staging/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkDelegate.java b/chrome/android/java_staging/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkDelegate.java
index 375ada0c1fae4edf26c70065642b01e1064f43c9..cbe3805fb65ed5fc0be0bf5279e9e7ab9d1cd3c8 100644
--- a/chrome/android/java_staging/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkDelegate.java
+++ b/chrome/android/java_staging/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkDelegate.java
@@ -4,9 +4,7 @@
package org.chromium.chrome.browser.enhancedbookmarks;
-import android.support.annotation.Nullable;
import android.support.v4.widget.DrawerLayout;
-import android.view.View;
import org.chromium.chrome.browser.enhanced_bookmarks.EnhancedBookmarksModel;
import org.chromium.chrome.browser.enhanced_bookmarks.LaunchLocation;
@@ -111,16 +109,6 @@ interface EnhancedBookmarkDelegate {
void openBookmark(BookmarkId bookmark, int launchLocation);
/**
- * Starts detail activity with shared element animation. On Lollipop and later devices, shows a
- * shared image animation. On earlier devices, opens the activity using the standard Activity
- * transition.
- * @param bookmarkId The bookmark that the detail activity shows.
- * @param view The view to share for activity transition animation. If null, no transition is
- * displayed.
- */
- void startDetailActivity(BookmarkId bookmarkId, @Nullable View view);
-
- /**
* Closes the EnhancedBookmark Activity on Phone. Does nothing on tablet.
*/
void finishActivityOnPhone();

Powered by Google App Engine
This is Rietveld 408576698