Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3731)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/enhanced_bookmarks/EnhancedBookmarksBridge.java

Issue 1182083005: Re-engineer edit screen in enhanced bookmark (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove description code in native, use new UI wedgit Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/enhanced_bookmarks/EnhancedBookmarksBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/enhanced_bookmarks/EnhancedBookmarksBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/enhanced_bookmarks/EnhancedBookmarksBridge.java
index 867b205a513dc475bcde386af9d69670cfd4e3cc..86817f6f32bcc528f5e405f83bff45258122617a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/enhanced_bookmarks/EnhancedBookmarksBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/enhanced_bookmarks/EnhancedBookmarksBridge.java
@@ -93,25 +93,6 @@ public final class EnhancedBookmarksBridge {
}
/**
- * Get descriptions of a given bookmark.
- * @param id The id of the bookmark to look at.
- * @return Description of the bookmark. If given a partner bookmark, this method will return an
- * empty list.
- */
- public String getBookmarkDescription(BookmarkId id) {
- return nativeGetBookmarkDescription(mNativeEnhancedBookmarksBridge, id.getId(),
- id.getType());
- }
-
- /**
- * Sets the description of the given bookmark.
- */
- public void setBookmarkDescription(BookmarkId id, String description) {
- nativeSetBookmarkDescription(mNativeEnhancedBookmarksBridge, id.getId(), id.getType(),
- description);
- }
-
- /**
* Request bookmark salient image for the given URL. Please refer to
* |BookmarkImageService::SalientImageForUrl|.
* @return True if this method is executed synchronously. False if
@@ -185,10 +166,6 @@ public final class EnhancedBookmarksBridge {
private native long nativeInit(Profile profile);
private native void nativeDestroy(long nativeEnhancedBookmarksBridge);
- private native String nativeGetBookmarkDescription(long nativeEnhancedBookmarksBridge, long id,
- int type);
- private native void nativeSetBookmarkDescription(long nativeEnhancedBookmarksBridge, long id,
- int type, String description);
private native BookmarkId nativeAddFolder(long nativeEnhancedBookmarksBridge, BookmarkId parent,
int index, String title);
private native void nativeMoveBookmark(long nativeEnhancedBookmarksBridge,

Powered by Google App Engine
This is Rietveld 408576698