chrome/android/java_staging/src/org/chromium/chrome/browser/ntp/BookmarkItemView.java - Issue 1182083005: Re-engineer edit screen in enhanced bookmark

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java_staging/src/org/chromium/chrome/browser/ntp/BookmarkItemView.java

Issue 1182083005: Re-engineer edit screen in enhanced bookmark (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java_staging/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkEditActivity.java ('K') | « chrome/android/java_staging/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUtils.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java_staging/src/org/chromium/chrome/browser/ntp/BookmarkItemView.java

diff --git a/chrome/android/java_staging/src/org/chromium/chrome/browser/ntp/BookmarkItemView.java b/chrome/android/java_staging/src/org/chromium/chrome/browser/ntp/BookmarkItemView.java

index c5a9c257d63c9e15fad0a112c7da3dbb7360cb10..b49c9a934adf22f917051d5b58517c621180fd8e 100644

--- a/chrome/android/java_staging/src/org/chromium/chrome/browser/ntp/BookmarkItemView.java

+++ b/chrome/android/java_staging/src/org/chromium/chrome/browser/ntp/BookmarkItemView.java

@@ -220,9 +220,9 @@ class BookmarkItemView extends AppCompatTextView implements OnCreateContextMenuL

R.string.contextmenu_open_in_incognito_tab).setOnMenuItemClickListener(this);

}

if (mIsEditable && !mManager.isIncognito()) {

- menu.add(Menu.NONE, ID_EDIT, Menu.NONE, mIsFolder

- ? R.string.contextmenu_edit_folder : R.string.contextmenu_edit_bookmark)

- .setOnMenuItemClickListener(this);

+ menu.add(Menu.NONE, ID_EDIT, Menu.NONE,

+ mIsFolder ? R.string.contextmenu_edit_folder : R.string.edit_bookmark)

Kibeom Kim (inactive) 2015/06/17 06:10:30 I think we should also update the comment for IDS_

Ian Wen 2015/06/17 21:07:42 Done.

+ .setOnMenuItemClickListener(this);

menu.add(Menu.NONE, ID_DELETE, Menu.NONE, mIsFolder

? R.string.contextmenu_delete_folder : R.string.contextmenu_delete_bookmark)

.setOnMenuItemClickListener(this);