Re-engineer edit screen in enhanced bookmark

chrome/android/java_staging/res/layout/eb_edit.xml

Index: chrome/android/java_staging/res/layout/eb_edit.xml
diff --git a/chrome/android/java_staging/res/layout/eb_edit.xml b/chrome/android/java_staging/res/layout/eb_edit.xml
new file mode 100644
index 0000000000000000000000000000000000000000..141c9882ccb5f1bc992a739f49a0967f768a5a67
--- /dev/null
+++ b/chrome/android/java_staging/res/layout/eb_edit.xml
@@ -0,0 +1,63 @@
+<ScrollView xmlns:android="http://schemas.android.com/apk/res/android"

[newt (away), 2015/06/17 04:42:22]

copyright

[Ian Wen, 2015/06/17 21:07:41]

Done.

+    android:layout_width="match_parent"
+    android:layout_height="match_parent" >
+
+    <LinearLayout
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:layout_marginEnd="16dp"
+        android:layout_marginStart="16dp"
+        android:layout_marginTop="8dp"

[newt (away), 2015/06/17 04:42:22]

why not margin bottom?

[Ian Wen, 2015/06/17 21:07:42]

Because on tablet the size of the dialog is fixed and setting margin won't
affect its size. On phone 99% of the devices are large enough to hold the simple
content.

[newt (away), 2015/06/17 23:53:25]

99%? This doesn't sound very scientific ;) What about in multi-window mode, or
in landscape on small devices? In any case, I'd add a marginBottom for symmetry.

+        android:orientation="vertical" >
+
+        <org.chromium.chrome.browser.widget.FloatLabelLayout

[Kibeom Kim (inactive), 2015/06/17 06:10:30]

Maybe TODO or a bug for TextInputLayout migration in design support library
http://android-developers.blogspot.com/2015/05/android-design-support-library...
?

[Ian Wen, 2015/06/17 21:07:42]

I knew this package exists. However it might not be this CL's responsibility to
touch it. Adding the design support library to chrome might increase the apk
size and it should be done with discretion. Even if we decide to do it later,
FloatLabelLayout will be deleted completely and autofill UIs will need to be
updated as well (see the javadoc for FloatLabelLayout). I think twellington has
a bug to clean this class up.

+            android:layout_width="match_parent"
+            android:layout_height="wrap_content" >
+
+            <EditText
+                android:id="@+id/title_text"
+                android:layout_width="match_parent"
+                android:layout_height="wrap_content"
+                android:hint="@string/bookmark_name"
+                android:imeOptions="flagNoExtractUi"
+                android:inputType="textCapSentences|textAutoCorrect"
+                android:singleLine="true" />
+        </org.chromium.chrome.browser.widget.FloatLabelLayout>
+
+        <TextView
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:paddingEnd="3dp"
+            android:paddingStart="3dp"
+            android:paddingTop="8dp"
+            android:text="@string/bookmark_folder"
+            android:textAppearance="@android:style/TextAppearance.Small" />

[newt (away), 2015/06/17 04:42:22]

I believe TextAppearance.Small and TextAppearance.Medium look different on pre-L
vs L devices. You should check and see if these are correct for your needs on
both L and pre-L devices. If not, you can set the size and color explicitly, or
perhaps use a style from AppCompat.

[Ian Wen, 2015/06/17 21:07:42]

Switched to TextAppearance.AppCompat.Small

+
+        <TextView
+            android:id="@+id/folder_text"
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            android:clickable="true"

[newt (away), 2015/06/17 04:42:22]

FYI, you don't need to set clickable="true". If you apply a click listener in
Java code, the clickable attribute will automatically be set to true.

[Ian Wen, 2015/06/17 21:07:42]

I added it to experiment whether setting clickable will give me a color state
list for free. The answer was no and I forgot to clean it up. Done.

+            android:paddingBottom="8dp"
+            android:paddingEnd="3dp"
+            android:paddingStart="3dp"
+            android:paddingTop="8dp"
+            android:textAppearance="@android:style/TextAppearance.Medium"
+            android:textColor="@color/dark_mode_tint" />
+
+        <org.chromium.chrome.browser.widget.FloatLabelLayout
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content" >
+
+            <EditText
+                android:id="@+id/url_text"
+                android:layout_width="match_parent"
+                android:layout_height="wrap_content"
+                android:hint="@string/bookmark_url"
+                android:imeOptions="flagNoExtractUi"
+                android:inputType="textUri"
+                android:singleLine="true" />
+        </org.chromium.chrome.browser.widget.FloatLabelLayout>
+    </LinearLayout>
+
+</ScrollView>