chrome/android/java_staging/res/layout/eb_edit.xml - Issue 1182083005: Re-engineer edit screen in enhanced bookmark

Side by Side Diff: chrome/android/java_staging/res/layout/eb_edit.xml

Issue 1182083005: Re-engineer edit screen in enhanced bookmark (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java_staging/res/layout/eb_detail.xml ('k') | chrome/android/java_staging/res/menu/eb_action_bar_menu.xml » ('j') | chrome/android/java_staging/res/values-v17/styles_staging.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <ScrollView xmlns:android="http://schemas.android.com/apk/res/android"
	newt (away) 2015/06/17 04:42:22 copyright copyright Ian Wen 2015/06/17 21:07:41 Done. Show quoted text On 2015/06/17 04:42:22, newt wrote: > copyright Done.
	2 android:layout_width="match_parent"

	3 android:layout_height="match_parent" >

	4

	5 <LinearLayout

	6 android:layout_width="match_parent"

	7 android:layout_height="wrap_content"

	8 android:layout_marginEnd="16dp"

	9 android:layout_marginStart="16dp"

	10 android:layout_marginTop="8dp"
	newt (away) 2015/06/17 04:42:22 why not margin bottom? why not margin bottom? Ian Wen 2015/06/17 21:07:42 Because on tablet the size of the dialog is fixed Show quoted text On 2015/06/17 04:42:22, newt wrote: > why not margin bottom? Because on tablet the size of the dialog is fixed and setting margin won't affect its size. On phone 99% of the devices are large enough to hold the simple content. newt (away) 2015/06/17 23:53:25 99%? This doesn't sound very scientific ;) What ab Show quoted text On 2015/06/17 21:07:42, Ian Wen wrote: > On 2015/06/17 04:42:22, newt wrote: > > why not margin bottom? > > Because on tablet the size of the dialog is fixed and setting margin won't > affect its size. On phone 99% of the devices are large enough to hold the simple > content. 99%? This doesn't sound very scientific ;) What about in multi-window mode, or in landscape on small devices? In any case, I'd add a marginBottom for symmetry.
	11 android:orientation="vertical" >

	12

	13 <org.chromium.chrome.browser.widget.FloatLabelLayout
	Kibeom Kim (inactive) 2015/06/17 06:10:30 Maybe TODO or a bug for TextInputLayout migration Maybe TODO or a bug for TextInputLayout migration in design support library http://android-developers.blogspot.com/2015/05/android-design-support-library... ? Ian Wen 2015/06/17 21:07:42 I knew this package exists. However it might not b Show quoted text On 2015/06/17 06:10:30, Kibeom Kim wrote: > Maybe TODO or a bug for TextInputLayout migration in design support library > http://android-developers.blogspot.com/2015/05/android-design-support-library... > ? I knew this package exists. However it might not be this CL's responsibility to touch it. Adding the design support library to chrome might increase the apk size and it should be done with discretion. Even if we decide to do it later, FloatLabelLayout will be deleted completely and autofill UIs will need to be updated as well (see the javadoc for FloatLabelLayout). I think twellington has a bug to clean this class up.
	14 android:layout_width="match_parent"

	15 android:layout_height="wrap_content" >

	16

	17 <EditText

	18 android:id="@+id/title_text"

	19 android:layout_width="match_parent"

	20 android:layout_height="wrap_content"

	21 android:hint="@string/bookmark_name"

	22 android:imeOptions="flagNoExtractUi"

	23 android:inputType="textCapSentences\|textAutoCorrect"

	24 android:singleLine="true" />

	25 </org.chromium.chrome.browser.widget.FloatLabelLayout>

	26

	27 <TextView

	28 android:layout_width="wrap_content"

	29 android:layout_height="wrap_content"

	30 android:paddingEnd="3dp"

	31 android:paddingStart="3dp"

	32 android:paddingTop="8dp"

	33 android:text="@string/bookmark_folder"

	34 android:textAppearance="@android:style/TextAppearance.Small" />
	newt (away) 2015/06/17 04:42:22 I believe TextAppearance.Small and TextAppearance. I believe TextAppearance.Small and TextAppearance.Medium look different on pre-L vs L devices. You should check and see if these are correct for your needs on both L and pre-L devices. If not, you can set the size and color explicitly, or perhaps use a style from AppCompat. Ian Wen 2015/06/17 21:07:42 Switched to TextAppearance.AppCompat.Small Show quoted text On 2015/06/17 04:42:22, newt wrote: > I believe TextAppearance.Small and TextAppearance.Medium look different on pre-L > vs L devices. You should check and see if these are correct for your needs on > both L and pre-L devices. If not, you can set the size and color explicitly, or > perhaps use a style from AppCompat. Switched to TextAppearance.AppCompat.Small
	35

	36 <TextView

	37 android:id="@+id/folder_text"

	38 android:layout_width="match_parent"

	39 android:layout_height="wrap_content"

	40 android:clickable="true"
	newt (away) 2015/06/17 04:42:22 FYI, you don't need to set clickable="true". If yo FYI, you don't need to set clickable="true". If you apply a click listener in Java code, the clickable attribute will automatically be set to true. Ian Wen 2015/06/17 21:07:42 I added it to experiment whether setting clickable Show quoted text On 2015/06/17 04:42:22, newt wrote: > FYI, you don't need to set clickable="true". If you apply a click listener in > Java code, the clickable attribute will automatically be set to true. I added it to experiment whether setting clickable will give me a color state list for free. The answer was no and I forgot to clean it up. Done.
	41 android:paddingBottom="8dp"

	42 android:paddingEnd="3dp"

	43 android:paddingStart="3dp"

	44 android:paddingTop="8dp"

	45 android:textAppearance="@android:style/TextAppearance.Medium"

	46 android:textColor="@color/dark_mode_tint" />

	47

	48 <org.chromium.chrome.browser.widget.FloatLabelLayout

	49 android:layout_width="match_parent"

	50 android:layout_height="wrap_content" >

	51

	52 <EditText

	53 android:id="@+id/url_text"

	54 android:layout_width="match_parent"

	55 android:layout_height="wrap_content"

	56 android:hint="@string/bookmark_url"

	57 android:imeOptions="flagNoExtractUi"

	58 android:inputType="textUri"

	59 android:singleLine="true" />

	60 </org.chromium.chrome.browser.widget.FloatLabelLayout>

	61 </LinearLayout>

	62

	63 </ScrollView>

OLD	NEW