Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(11)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1182073002: cross-origin: Adds W3C cross-origin security tests. (Closed)

Created:
4 years, 10 months ago by Yuki
Modified:
4 years, 10 months ago
Reviewers:
haraken, tkent
CC:
blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

cross-origin: Adds W3C cross-origin security tests. Adds the following test to Blink LayoutTests. https://github.com/w3c/web-platform-tests/tree/master/html/browsers/origin/cross-origin-objects Patch Set 1 is a simple copy of the test. We need to tweak the test a little in order to make it fit in LayoutTests. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197106

Patch Set 1 : Simple copy from the site. #

Patch Set 2 : Tweaked a little to fit in LayoutTests/http/tests/. #

Patch Set 3 : Added a link to the original test. #

Total comments: 2

Patch Set 4 : Synced. #

Patch Set 5 : Updated a comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+461 lines, -0 lines) Patch
A LayoutTests/http/tests/security/w3c/cross-origin-objects.html View 1 2 3 4 1 chunk +349 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/security/w3c/cross-origin-objects-expected.txt View 1 1 chunk +22 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/security/w3c/resources/frame.html View 1 chunk +35 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/security/w3c/resources/win-documentdomain.html View 1 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Yuki
Could you review this CL?
4 years, 10 months ago (2015-06-12 14:06:12 UTC) #2
haraken
LGTM https://codereview.chromium.org/1182073002/diff/40001/LayoutTests/http/tests/security/w3c/cross-origin-objects.html File LayoutTests/http/tests/security/w3c/cross-origin-objects.html (right): https://codereview.chromium.org/1182073002/diff/40001/LayoutTests/http/tests/security/w3c/cross-origin-objects.html#newcode1 LayoutTests/http/tests/security/w3c/cross-origin-objects.html:1: <!doctype html> Shall we add a TODO and ...
4 years, 10 months ago (2015-06-12 15:13:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182073002/80001
4 years, 10 months ago (2015-06-15 09:00:10 UTC) #6
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://src.chromium.org/viewvc/blink?view=rev&revision=197106
4 years, 10 months ago (2015-06-15 09:53:09 UTC) #7
Yuki
https://codereview.chromium.org/1182073002/diff/40001/LayoutTests/http/tests/security/w3c/cross-origin-objects.html File LayoutTests/http/tests/security/w3c/cross-origin-objects.html (right): https://codereview.chromium.org/1182073002/diff/40001/LayoutTests/http/tests/security/w3c/cross-origin-objects.html#newcode1 LayoutTests/http/tests/security/w3c/cross-origin-objects.html:1: <!doctype html> On 2015/06/12 15:13:16, haraken wrote: > > ...
4 years, 10 months ago (2015-06-15 10:06:03 UTC) #8
tkent
The test is very unstable. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fsecurity%2Fw3c%2Fcross-origin-objects.html
4 years, 10 months ago (2015-06-16 22:41:40 UTC) #10
Yuki
4 years, 10 months ago (2015-06-17 07:27:37 UTC) #11
Message was sent while issue was closed. 
On 2015/06/16 22:41:40, tkent wrote:
> The test is very unstable.
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=htt...

Thanks for letting me know.  Addressing at:
https://codereview.chromium.org/1189983002/

Powered by Google App Engine
This is Rietveld 408576698