ui/display/chromeos/display_configurator.cc - Issue 1182063002: Add support for more advanced color correction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/display/chromeos/display_configurator.cc

Issue 1182063002: Add support for more advanced color correction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@qcms-fixed-point-gamma

Patch Set: Address spang@ & dcheng@ feedback Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/display/display_color_manager_chromeos_unittest.cc ('K') | « ui/display/chromeos/display_configurator.h ('k') | ui/display/chromeos/display_snapshot_virtual.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/display/chromeos/display_configurator.cc

diff --git a/ui/display/chromeos/display_configurator.cc b/ui/display/chromeos/display_configurator.cc

index 370c7c142d993d082ae494d89c00b73c4680b40d..88ffec38b258a5b81bc9f203a11ad193ed3fdb34 100644

--- a/ui/display/chromeos/display_configurator.cc

+++ b/ui/display/chromeos/display_configurator.cc

@@ -822,12 +822,15 @@ bool DisplayConfigurator::SetColorCalibrationProfile(

return false;

}

-bool DisplayConfigurator::SetGammaRamp(

+bool DisplayConfigurator::SetColorCorrection(

int64_t display_id,

- const std::vector<GammaRampRGBEntry>& lut) {

+ const std::vector<GammaRampRGBEntry>& degamma_lut,

+ const std::vector<GammaRampRGBEntry>& gamma_lut,

+ const std::vector<float>& correction_matrix) {

for (const DisplaySnapshot* display : cached_displays_) {

if (display->display_id() == display_id)

- return native_display_delegate_->SetGammaRamp(*display, lut);

+ return native_display_delegate_->SetColorCorrection(

+ *display, degamma_lut, gamma_lut, correction_matrix);

}

return false;