Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1182053013: Revert of Ship arrow functions (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
Reviewers:
wingo, rossberg
CC:
v8-dev, Dmitry Lomov (no reviews), arv (Not doing code reviews)
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Ship arrow functions (patchset #1 id:1 of https://codereview.chromium.org/1187173004/) Reason for revert: [Sheriff] Breaks layout tests. Please submit a needsmanualrebaseline change on the blink side for the expectations if intended. E.g. http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/545 Original issue's description: > Ship arrow functions > > R=rossberg@chromium.org > LOG=Y > BUG=v8:2700 > > Committed: https://crrev.com/541b6c39e0ecae1c070f51fae8e9e3dab18d278c > Cr-Commit-Position: refs/heads/master@{#29119} TBR=rossberg@chromium.org,wingo@igalia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:2700 Committed: https://crrev.com/bf92b53ff6724d6987dda643a9263135918fe051 Cr-Commit-Position: refs/heads/master@{#29125}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Ship arrow functions
5 years, 6 months ago (2015-06-18 19:39:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182053013/1
5 years, 6 months ago (2015-06-18 19:39:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-18 19:39:47 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 19:39:57 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf92b53ff6724d6987dda643a9263135918fe051
Cr-Commit-Position: refs/heads/master@{#29125}

Powered by Google App Engine
This is Rietveld 408576698