Issue 1182053013: Revert of Ship arrow functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1182053013: Revert of Ship arrow functions (Closed)

Created:
5 years, 6 months ago by Michael Achenbach

Modified:
5 years, 6 months ago

Reviewers:
wingo, rossberg

CC:
v8-dev, Dmitry Lomov (no reviews), arv (Not doing code reviews)

Base URL:
https://chromium.googlesource.com/v8/v8@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of Ship arrow functions (patchset #1 id:1 of https://codereview.chromium.org/1187173004/) Reason for revert: [Sheriff] Breaks layout tests. Please submit a needsmanualrebaseline change on the blink side for the expectations if intended. E.g. http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/545 Original issue's description: > Ship arrow functions > > R=rossberg@chromium.org > LOG=Y > BUG=v8:2700 > > Committed: https://crrev.com/541b6c39e0ecae1c070f51fae8e9e3dab18d278c > Cr-Commit-Position: refs/heads/master@{#29119} TBR=rossberg@chromium.org,wingo@igalia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:2700 Committed: https://crrev.com/bf92b53ff6724d6987dda643a9263135918fe051 Cr-Commit-Position: refs/heads/master@{#29125}

Created: 5 years, 6 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/flag-definitions.h	View		2 chunks	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182053013/1

5 years, 6 months ago (2015-06-18 19:39:36 UTC) #2

commit-bot: I haz the power

5 years, 6 months ago (2015-06-18 19:39:57 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/bf92b53ff6724d6987dda643a9263135918fe051
Cr-Commit-Position: refs/heads/master@{#29125}