Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1182053012: Rename editing2/ and theme2/ to editing/ and theme/. (Closed)

Created:
5 years, 6 months ago by Hixie
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Rename editing2/ and theme2/ to editing/ and theme/. Flesh out a README.md file for the SDK. Make the stocks app test wait for the app to be mounted, to catch some more errors, like typos in the mount callback. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1687a6c603b3b3b33fcab92b50baa029cd6a06ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -834 lines) Patch
M sky/examples/rendering/shadowed_box.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/examples/rendering/touch_demo.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/stocks2/lib/stock_arrow.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/stocks2/lib/stock_home.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/examples/stocks2/lib/stock_row.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/stocks2/lib/stock_settings.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/examples/widgets/sector.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/home.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/sdk/BUILD.gn View 3 chunks +9 lines, -11 lines 0 comments Download
A sky/sdk/lib/README.md View 1 chunk +66 lines, -0 lines 0 comments Download
D sky/sdk/lib/editing2/editable_string.dart View 1 chunk +0 lines, -122 lines 0 comments Download
D sky/sdk/lib/editing2/editable_text.dart View 1 chunk +0 lines, -98 lines 0 comments Download
D sky/sdk/lib/editing2/input.dart View 1 chunk +0 lines, -101 lines 0 comments Download
D sky/sdk/lib/editing2/keyboard.dart View 1 chunk +0 lines, -21 lines 0 comments Download
D sky/sdk/lib/framework/README.md View 1 chunk +0 lines, -22 lines 0 comments Download
D sky/sdk/lib/theme2/colors.dart View 1 chunk +0 lines, -253 lines 0 comments Download
D sky/sdk/lib/theme2/edges.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D sky/sdk/lib/theme2/shadows.dart View 1 chunk +0 lines, -60 lines 0 comments Download
D sky/sdk/lib/theme2/typography.dart View 1 chunk +0 lines, -53 lines 0 comments Download
D sky/sdk/lib/theme2/view_configuration.dart View 1 chunk +0 lines, -40 lines 0 comments Download
M sky/sdk/lib/widgets/checkbox.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/drawer.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/drawer_header.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/flat_button.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/floating_action_button.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/material.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/sdk/lib/widgets/popup_menu.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/radio.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/raised_button.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/scaffold.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/scrollable.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/switch.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/tool_bar.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/examples/stocks.dart View 1 chunk +15 lines, -1 line 0 comments Download
M sky/tests/examples/stocks-expected.txt View 1 chunk +49 lines, -1 line 0 comments Download
M sky/tests/raw/render_box.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 6 months ago (2015-06-18 19:42:24 UTC) #2
Hixie
5 years, 6 months ago (2015-06-18 19:44:15 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
1687a6c603b3b3b33fcab92b50baa029cd6a06ae (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698