Correct box shadow overflow computation for InlineFlowBox

Correct box shadow overflow computation for InlineFlowBox

InlineFlowBox::addBoxShadowVisualOverflow() has an early exit condition that
doesn't match the logic in InlineFlowBoxPainter::paintBoxDecorationBackground(),
resulting in under-reported visual overflow. This CL makes correction to that.

Similar adjustment is made to InlineFlowBox::addBorderOutsetVisualOverflow()
in this CL too.

BUG=498848
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197412

[trchen, 2015-06-18 01:09:13]

The CQ bit was checked by trchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-18 01:09:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1182053009/1

[trchen, 2015-06-18 01:10:07]

trchen@chromium.org changed reviewers:
+ schenney@chromium.org

[trchen, 2015-06-18 01:10:08]

One-liner. PTAL. Thanks!

[commit-bot: I haz the power, 2015-06-18 02:52:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-18 02:52:27]

Dry run: This issue passed the CQ dry run.

[fs, 2015-06-18 08:47:32]

fs@opera.com changed reviewers:
+ jchaffraix@chromium.org, leviw@chromium.org

[fs, 2015-06-18 08:47:33]

https://codereview.chromium.org/1182053009/diff/1/Source/core/layout/line/Inl...
File Source/core/layout/line/InlineFlowBox.cpp (right):

https://codereview.chromium.org/1182053009/diff/1/Source/core/layout/line/Inl...
Source/core/layout/line/InlineFlowBox.cpp:751: if (!parent() &&
(!isFirstLineStyle() || &style == layoutObject().style()))
This is also true for border-image outsets and outline (below), so seems
reasonable to extend those predicates in the same way.

[trchen, 2015-06-18 21:44:12]

On 2015/06/18 08:47:33, fs wrote:
>
https://codereview.chromium.org/1182053009/diff/1/Source/core/layout/line/Inl...
> File Source/core/layout/line/InlineFlowBox.cpp (right):
> 
>
https://codereview.chromium.org/1182053009/diff/1/Source/core/layout/line/Inl...
> Source/core/layout/line/InlineFlowBox.cpp:751: if (!parent() &&
> (!isFirstLineStyle() || &style == layoutObject().style()))
> This is also true for border-image outsets and outline (below), so seems
> reasonable to extend those predicates in the same way.

Thanks for pointing out! I applied the change to
InlineFlowBox::addBorderOutsetVisualOverflow() too.

For the outline, I examined InlineFlowBoxPainter::paint() it doesn't seem to
respect :first-line, thus unchanged. (I don't know which way is more standard
compliant.)

Note: No new tests are needed because they will be caught by strict cull rect
checking.

[trchen, 2015-06-18 21:44:18]

The CQ bit was checked by trchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-18 21:45:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1182053009/20001

[fs, 2015-06-18 23:24:09]

On 2015/06/18 21:44:12, trchen wrote:
> On 2015/06/18 08:47:33, fs wrote:
> >
>
https://codereview.chromium.org/1182053009/diff/1/Source/core/layout/line/Inl...
> > File Source/core/layout/line/InlineFlowBox.cpp (right):
> > 
> >
>
https://codereview.chromium.org/1182053009/diff/1/Source/core/layout/line/Inl...
> > Source/core/layout/line/InlineFlowBox.cpp:751: if (!parent() &&
> > (!isFirstLineStyle() || &style == layoutObject().style()))
> > This is also true for border-image outsets and outline (below), so seems
> > reasonable to extend those predicates in the same way.
> 
> Thanks for pointing out! I applied the change to
> InlineFlowBox::addBorderOutsetVisualOverflow() too.
> 
> For the outline, I examined InlineFlowBoxPainter::paint() it doesn't seem to
> respect :first-line, thus unchanged. (I don't know which way is more standard
> compliant.)

Right, 'outline' isn't in the ::first-line whitelist.

LGTM, but you may want second opinions.

[commit-bot: I haz the power, 2015-06-18 23:55:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-18 23:55:46]

Dry run: This issue passed the CQ dry run.

[trchen, 2015-06-19 00:02:32]

On 2015/06/18 23:24:09, fs wrote:
> LGTM, but you may want second opinions.

I feel this is pretty safe. I'll just land it gahahahaha.

[trchen, 2015-06-19 00:02:39]

The CQ bit was checked by trchen@chromium.org

[commit-bot: I haz the power, 2015-06-19 00:03:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1182053009/20001

[commit-bot: I haz the power, 2015-06-19 00:07:46]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197412