Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 118203002: During virtual context switches only restore texture units that have changed from the previous cont… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use the delta between the ContextStates to decide if we should bind a texture or not Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/gles2_cmd_decoder.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc
index 724d537d7a7039de659aeba7ab542f7532ed7765..018dbcda9bef9b4e40e456638f0c193535ba5532 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc
@@ -545,13 +545,13 @@ class GLES2DecoderImpl : public GLES2Decoder,
virtual gfx::GLContext* GetGLContext() OVERRIDE { return context_.get(); }
virtual ContextGroup* GetContextGroup() OVERRIDE { return group_.get(); }
virtual Capabilities GetCapabilities() OVERRIDE;
- virtual void RestoreState() const OVERRIDE;
+ virtual void RestoreState(const ContextState* prev_state) const OVERRIDE;
virtual void RestoreActiveTexture() const OVERRIDE {
state_.RestoreActiveTexture();
}
virtual void RestoreAllTextureUnitBindings() const OVERRIDE {
- state_.RestoreAllTextureUnitBindings();
+ state_.RestoreAllTextureUnitBindings(NULL);
}
virtual void RestoreAttribute(unsigned index) const OVERRIDE {
state_.RestoreAttribute(index);
@@ -569,7 +569,7 @@ class GLES2DecoderImpl : public GLES2Decoder,
state_.RestoreRenderbufferBindings();
}
virtual void RestoreTextureUnitBindings(unsigned unit) const OVERRIDE {
- state_.RestoreTextureUnitBindings(unit);
+ state_.RestoreTextureUnitBindings(unit, NULL);
}
virtual void RestoreFramebufferBindings() const OVERRIDE;
virtual void RestoreTextureState(unsigned service_id) const OVERRIDE;
@@ -591,6 +591,7 @@ class GLES2DecoderImpl : public GLES2Decoder,
virtual Logger* GetLogger() OVERRIDE;
virtual ErrorState* GetErrorState() OVERRIDE;
+ virtual const ContextState* GetContextState() OVERRIDE { return &state_; }
virtual void SetShaderCacheCallback(
const ShaderCacheCallback& callback) OVERRIDE;
@@ -3761,14 +3762,14 @@ GLuint GLES2DecoderImpl::GetBackbufferServiceId() const {
: (surface_.get() ? surface_->GetBackingFrameBufferObject() : 0);
}
-void GLES2DecoderImpl::RestoreState() const {
+void GLES2DecoderImpl::RestoreState(const ContextState* prev_state) const {
TRACE_EVENT1("gpu", "GLES2DecoderImpl::RestoreState",
"context", logger_.GetLogPrefix());
// Restore the Framebuffer first because of bugs in Intel drivers.
// Intel drivers incorrectly clip the viewport settings to
// the size of the current framebuffer object.
RestoreFramebufferBindings();
- state_.RestoreState();
+ state_.RestoreState(prev_state);
}
void GLES2DecoderImpl::RestoreFramebufferBindings() const {

Powered by Google App Engine
This is Rietveld 408576698