Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 11820065: Revert 176198 (Closed)

Created:
7 years, 11 months ago by Yaron
Modified:
7 years, 11 months ago
Reviewers:
Steve McKay
CC:
chromium-reviews, jam, klundberg+watch_chromium.org, ilevy+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, yfriedman+watch_chromium.org, bulach+watch_chromium.org, peter+watch_chromium.org, android-webview-reviews_chromium.org, jochen+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Revert 176198 Fixed permissions on build/android/envsetup.sh > Revert 176176 > > Update Android build to API level 17 and SDK Tools version 21 > > > > Some fixes included: > > - Changes to resource management to account for new R.java packaging > > from library projects > > (https://android-review.googlesource.com/#/c/43134/). > > - Fixed the package for some inludes in ModalDialogTest.java. This only > > worked because of how we previously used to aggregate all resoures > > from the prior layer. With the new packaging, we must use the resource > > from the appropriate layer. > > > > BUG=163001, 166434 > > NOTRY=true > > > > Review URL: https://chromiumcodereview.appspot.com/11819047 > > TBR=yfriedman@chromium.org > Review URL: https://codereview.chromium.org/11783108 TBR=smckay@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176202

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -17 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/java/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/AndroidManifest.xml View 1 chunk +2 lines, -1 line 0 comments Download
M build/android/ant/chromium-apk.xml View 1 chunk +3 lines, -0 lines 0 comments Download
M build/android/ant/create-test-jar.js View 2 chunks +0 lines, -4 lines 0 comments Download
MM build/android/envsetup.sh View 1 chunk +1 line, -1 line 0 comments Download
M build/android/process_resources.py View 1 chunk +1 line, -0 lines 0 comments Download
M build/java.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M build/java_apk.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/testshell/java/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/testshell/javatests/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/java/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/javatests/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M testing/android/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Yaron
7 years, 11 months ago (2013-01-10 23:32:42 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698