Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 11820049: Revert 176061 (Closed)

Created:
7 years, 11 months ago by ricow1
Modified:
7 years, 11 months ago
Reviewers:
Ian Vollick
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
MM cc/layer_tree_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
ricow1
7 years, 11 months ago (2013-01-10 14:33:09 UTC) #1
ricow1
7 years, 11 months ago (2013-01-10 14:34:51 UTC) #2
and windows:
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%28...


On Thu, Jan 10, 2013 at 3:33 PM, <ricow@google.com> wrote:

> Reviewers: vollick,
>
> Description:
> Revert 176061
>
>> LTHI's bg animation timer should set the fake thread to impl.
>>
>
>  The single thread proxy expects this to be true.
>>
>
>  BUG=165399
>>
>
>
>  Review URL:
https://chromiumcodereview.**appspot.com/11532009<https://chromiumcodereview....
>>
> This is causing failures on mac:
>
> http://build.chromium.org/p/**chromium.mac/buildstatus?**
>
builder=Mac%2010.6%20Tests%20%**28dbg%29%281%29&number=32119<http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.6%20Tests%20%28dbg%29%281%29&number=32119>
> http://build.chromium.org/p/**chromium.mac/buildstatus?**
>
builder=Mac%2010.7%20Tests%20%**28dbg%29%281%29&number=5885<http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.7%20Tests%20%28dbg%29%281%29&number=5885>
>
> TBR=vollick@chromium.org
>
> Please review this at
https://codereview.chromium.**org/11820049/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>   MM    cc/layer_tree_host_impl.cc
>
>
> Index: cc/layer_tree_host_impl.cc
> ==============================**==============================**=======
> --- cc/layer_tree_host_impl.cc  (revision 176074)
> +++ cc/layer_tree_host_impl.cc  (working copy)
> @@ -71,7 +71,6 @@
>
>      virtual void onTimerTick() OVERRIDE
>      {
> -        DebugScopedSetImplThread setImplThread(m_**
> layerTreeHostImpl->proxy());
>          m_layerTreeHostImpl->animate(**base::TimeTicks::Now(),
> base::Time::Now());
>      }
>
>
> Property changes on: cc/layer_tree_host_impl.cc
> ______________________________**______________________________**_______
> Deleted: svn:mergeinfo
>
>
>
>

Powered by Google App Engine
This is Rietveld 408576698