Issue 11820035: [Telemetry] Only add android_tools' adb to the path if it exists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11820035: [Telemetry] Only add android_tools' adb to the path if it exists. (Closed)

Created:
7 years, 11 months ago by tonyg

Modified:
7 years, 11 months ago

Reviewers:
nduca

CC:
chromium-reviews, chrome-speed-team+watch_google.com, pam+watch_chromium.org, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Telemetry] Only add android_tools' adb to the path if it exists. This directory is only checked out when target_os=['android']. So we can't assume that adb will always be in the chrome checkout. TBR=nduca@chromium.org BUG=None TEST=./tools/perf/run_multipage_benchmarks --browser=list Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175864

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	tools/telemetry/telemetry/android_browser_finder.py	View		1 chunk	+7 lines, -5 lines	0 comments	Download